New issue
Advanced search Search tips

Issue 697229 link

Starred by 3 users
Status: WontFix
Owner:
ellyjo...@chromium.org
Closed: Aug 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 671916


Participants' hotlists:
MacViews-Task-Queue


Sign in to add a comment

[tracker] MacViewsBrowser: No macOS integration regressions

Project Member Reported by tapted@chromium.org, Feb 28 2017 
Generic bug to ensure the mac_views_browser build is fully integrated with the OS on Mac. This includes things like

 - Applescript
 - Drag & Drop
 - mainMenu, shortcuts overriding
 - editing commands / overrides / key bindings
 - Dock integration
 - Notifications
 - Titlebars / shadows / traffic lights
 - Expose / Command Centre
 - Scrolling
 - a11y
 - IME
 - Filetype/protocol handling
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b9b8af34eb0188a1684464d1d9ff0528c9234e5

commit 2b9b8af34eb0188a1684464d1d9ff0528c9234e5
Author: art-snake <art-snake@yandex-team.ru>
Date: Tue Mar 07 13:43:26 2017

MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, add related files into compilation and convert related tests based
on CocoaProfileTest into "Browser Tests". As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG= 697229 

Review-Url: https://codereview.chromium.org/2724603002
Cr-Commit-Position: refs/heads/master@{#455062}

[modify] https://crrev.com/2b9b8af34eb0188a1684464d1d9ff0528c9234e5/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/2b9b8af34eb0188a1684464d1d9ff0528c9234e5/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_test.h
[rename] https://crrev.com/2b9b8af34eb0188a1684464d1d9ff0528c9234e5/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_test.mm
[delete] https://crrev.com/4c17494f13d66aa009506994631a4772a27fd9d0/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.h
[rename] https://crrev.com/2b9b8af34eb0188a1684464d1d9ff0528c9234e5/chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript_browsertest.mm
[rename] https://crrev.com/2b9b8af34eb0188a1684464d1d9ff0528c9234e5/chrome/browser/ui/cocoa/applescript/bookmark_item_applescript_browsertest.mm
[modify] https://crrev.com/2b9b8af34eb0188a1684464d1d9ff0528c9234e5/chrome/test/BUILD.gn

Comment 2 by ellyjo...@chromium.org, Apr 12 2017

Labels: MacViews-Browser

Comment 3 by gov...@chromium.org, Feb 8 2018

Labels: M-68
[Bulk Edit]
Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied.

Comment 4 by ellyjo...@chromium.org, Mar 26 2018

Labels: -phase4 -M-68 Target-69
Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)
Summary: [tracker] MacViewsBrowser: No macOS integration regressions (was: MacViewsBrowser: No macOS integration regressions)
MacViews triage: this is a tracking bug; assigning to myself for M69.

Comment 5 by gov...@chromium.org, Mar 27 2018

Labels: M-69

Comment 6 by gov...@chromium.org, May 23 2018

Labels: Target-68

Comment 7 by robliao@chromium.org, Jun 20 2018

Labels: -Target-68

Comment 8 by robliao@chromium.org, Jul 12

Labels: -M-69 Group-Feature_Process

Comment 9 by robliao@chromium.org, Jul 12

Labels: M-69

Comment 10 by ellyjo...@chromium.org, Aug 2

Status: WontFix (was: Assigned)
MacViews triage: WontFix this tracker. We have a bug group for this in MacViews triage and this tracking bug is obsolete.
►

Sign in to add a comment