New issue
Advanced search Search tips

Issue 697216 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Stop using Microsoft's undocumented _THROW0() macro

Project Member Reported by cblume@chromium.org, Feb 28 2017

Issue description

We use the _THROW0() macro in src/courgette/memory_allocator.h but this macro is undocumented. We should be using noexcept instead, which is approved by the style guide.


Billy O'Neal at Microsoft mentioned people depends on this macro, unfortunately. Bruce Dawson found our usage in Chrome.

 
Twitter-driven programming
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bf02bd5b61add98b21b51c184579e15ecc49c45

commit 0bf02bd5b61add98b21b51c184579e15ecc49c45
Author: cblume <cblume@chromium.org>
Date: Mon Mar 20 22:50:29 2017

Stop using undocumented _THROW0() macro

Billy O'Neal at Microsoft mentioned people depend on this undocumented
macro. Bruce Dawson at Google noticed we use it in Chrome.

Context: https://twitter.com/BruceDawson0xB/status/836700784947441664

BUG= 697216 

Review-Url: https://codereview.chromium.org/2721983002
Cr-Commit-Position: refs/heads/master@{#458213}

[modify] https://crrev.com/0bf02bd5b61add98b21b51c184579e15ecc49c45/courgette/memory_allocator.h

Comment 4 by cblume@chromium.org, Mar 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment