You can see the desktop through it. Additionally the corners should be transparent.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94a9748c19572dbed81486360ff37d778d86c421 commit 94a9748c19572dbed81486360ff37d778d86c421 Author: sky <sky@chromium.org> Date: Wed Mar 01 05:24:51 2017 Makes mojo generator generate export for constants This is necessary in component builds otherwise you get link errors. BUG= 697206 TEST=none, but I'll soon land a mojom that uses this R=yzshen@chromium.org Review-Url: https://codereview.chromium.org/2721953003 Cr-Commit-Position: refs/heads/master@{#453854} [modify] https://crrev.com/94a9748c19572dbed81486360ff37d778d86c421/mojo/public/tools/bindings/generators/mojom_cpp_generator.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/350894479de57f66b60eb51726d96e1aab991374 commit 350894479de57f66b60eb51726d96e1aab991374 Author: sky <sky@chromium.org> Date: Thu Mar 02 00:04:25 2017 mash: makes ash/public/cpp bundle ash/public/interfaces A future change is going to require ash/public/cpp depend upon ash/public/interfaces. Because of typemaps ash/public/interfaces already depends upon ash/public/cpp. This means we would have a cycle. To fix this I'm making ash/public/interfaces only visible to ash/public/cpp and ash/public/cpp has a public_dep on ash/public/interfaces. BUG= 697206 TEST=none R=rockot@chromium.org, tsepez@chromium.org Review-Url: https://codereview.chromium.org/2720203004 Cr-Commit-Position: refs/heads/master@{#454106} [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/autoclick/mus/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/common/test/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/mus/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/public/cpp/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/public/interfaces/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/public/interfaces/session_controller.typemap [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/public/interfaces/shelf.typemap [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/public/interfaces/wallpaper.typemap [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/test/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/ash/touch_hud/mus/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/components/arc/BUILD.gn [modify] https://crrev.com/350894479de57f66b60eb51726d96e1aab991374/mash/common/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97 commit b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97 Author: sky <sky@chromium.org> Date: Mon Mar 06 20:25:11 2017 mash: improves frame rendering in mash BrowserFrameMus was created more than a year ago and had gotten a bit out of sync with other ash changes. This change gets browser windows looking better, but is really just a start. We really need to promote BrowserHeaderPainter to ash, but that's a bigger project. As I believe the non-client area should be rendered by ash we need a way for clients to signal they want windows to look like browser windows. This adds a WindowStyle that is meant to indicate that. This also makes DesktopWindowTreeHostMus windows opacity honor that set in the initparams, which is needed for browser windows as they are transparent. Lastly adds a couple of names to some of the apps, and makes the name of a Widget be set on the top-level window. BUG= 697206 TEST=none Review-Url: https://codereview.chromium.org/2724693002 Cr-Commit-Position: refs/heads/master@{#454938} [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/common/frame/custom_frame_view_ash.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/common/frame/custom_frame_view_ash.h [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/common/frame/default_header_painter.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/common/frame/default_header_painter.h [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/common/frame/header_view.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/common/frame/header_view.h [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/mus/frame/custom_frame_view_mus.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/mus/frame/custom_frame_view_mus.h [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/mus/non_client_frame_controller.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/mus/property_util.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/mus/property_util.h [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/public/cpp/BUILD.gn [add] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/public/cpp/window_style.cc [add] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/public/cpp/window_style.h [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/public/interfaces/BUILD.gn [add] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ash/public/interfaces/window_style.mojom [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/chrome/browser/ui/views/frame/browser_frame_mus.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.h [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/mash/quick_launch/quick_launch.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/b5e2126f04fe0ee4d9d418e2c2fa617bb7e37b97/ui/wm/core/shadow_types.h
Comment 1 by sky@chromium.org
, Mar 1 2017