New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697200 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

ninja build errors on windows NaCl SDK bot

Project Member Reported by sbc@chromium.org, Feb 28 2017

Issue description

The windows SDK bot has been seeing some strange ninja errors for a while now:

e.g: https://build.chromium.org/p/client.nacl.sdk/builders/windows-sdk-multirel/builds/5732

ninja: Entering directory `E:\b\build\slave\sdk-rel\build\src\out\Release'
ninja: error: '../../third_party/glslang-angle/src/glslang/GenericCodeGen/CodeGen.cpp', needed by 'obj/third_party/angle/src/vulkan_support/glslang/CodeGen.obj', missing and no known rule to make it
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

The error always seems to be related to vulkan_support sources.

I'm guessing is a platforms/recipes thing otherwise it would be effecting all windows builders.
 

Comment 1 by sbc@chromium.org, Feb 28 2017

Cc: jmad...@chromium.org
+jmadill, any idea why this might happen on a windows bot?  Seems related to vulkan_support somehow.
Cc: dpranke@chromium.org
Components: Internals>GPU>ANGLE
Labels: OS-Windows
Owner: jmad...@chromium.org
Status: Assigned (was: Untriaged)
Hmm, yes. The GN stuff is a bit hard for me to understand but nacl uses a totally separate checkout of ANGLE. It's probably not working well with Vulkan for some reason, we had problems with this before but managed to fix it. Looks like the fix wasn't sufficient. I'm out sick but will try to look at this - is the pri-3 rating accurate?

CC'ing Dirk, we talked about this a while back.
Sorry, it uses the same checkout, but different build directory/targets.
I'm not very familiar w/ the NaCL SDK layout, but I doubt this error is particularly hard to troubleshoot. Let me know if you need help once you start digging in. I suspect that either some path to the vulkan directory is wrong or possibly you're including things you shouldn't be.

Comment 5 by sbc@chromium.org, Mar 1 2017

This builder is simply trying to build chromium, and *then* build the NaCl SDK.  It builds chromium so it can use it to run tests against. 

So my understanding is that its not actually trying to build angle for NaCl here.  Seems to only effect the branch builds if that is clue.

Pri-3 is fine yes.  The SDK is in pretty much in maintenance mode these days anyway.
Cc: sugoi@chromium.org
Owner: sugoi@chromium.org
It looks as though a SwiftShader compile error has pre-empted the ANGLE error. Alexis we should probably figure this out together somehow.
Components: Internals>GPU>SwiftShader

Comment 8 by sugoi@chromium.org, Mar 27 2017

Hi Jamie,

I see the SwiftShader error you mentioned on the bots:

'../../third_party/swiftshader/third_party/pnacl-subzero/src/IceAssembler.cpp', needed by 'obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceAssembler.obj', missing and no known rule to make it

It seems SubZero is not getting pulled. In Chromium, SwiftShader DEPS are pulled through DEPS here:
https://cs.chromium.org/chromium/src/DEPS?type=cs&l=1150

And SwiftShader DEPS pull SubZero here:
https://cs.chromium.org/chromium/src/third_party/swiftshader/DEPS?type=cs&l=15

I don't know what's missing in this particular NaCl SDK bot build.

If I look at the bug description, it seems that both the SwiftShader issue and the Angle issue are files that failed to be pulled from DEPS.

Does this bot support the "recursedeps" field properly?
Not sure, it could be related to that.

Comment 10 by capn@chromium.org, Jun 14 2017

Owner: jmad...@chromium.org
Subzero is now part of the SwiftShader repository (using git-subtree), so it should no longer fail to build. The ANGLE issue is probaly still present, so reassigning this to Jamie.
Owner: sbc@chromium.org
Bot is failing for a different reason now. Assigning back to original issue creator sbc.

Comment 12 by sbc@chromium.org, Jun 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment