New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697189 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add test-only constructor for PageLoadExtraInfo.

Project Member Reported by bmcquade@chromium.org, Feb 28 2017

Issue description

prerender_browsertest.cc wants to create fake PageLoadExtraInfos.
We have to make a change there every time we update the constructor.
Add a helper that allows for construction of PLEIs using a minimal set of
parameters, in order to avoid the need to update
prerender_browsertest.cc in the future.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb24ee6ddf845f326802315fec6748f49e7e253d

commit eb24ee6ddf845f326802315fec6748f49e7e253d
Author: bmcquade <bmcquade@chromium.org>
Date: Tue Feb 28 23:30:40 2017

Add test-only constructor for PageLoadExtraInfo.

prerender_browsertest.cc wants to create fake PageLoadExtraInfos.
We have to make a change there every time we update the constructor.
This helper allows for construction of PLEIs using a minimal set of
parameters, in order to avoid the need to update
prerender_browsertest.cc in the future.

BUG= 697189 

Review-Url: https://codereview.chromium.org/2726673002
Cr-Commit-Position: refs/heads/master@{#453742}

[modify] https://crrev.com/eb24ee6ddf845f326802315fec6748f49e7e253d/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[modify] https://crrev.com/eb24ee6ddf845f326802315fec6748f49e7e253d/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/eb24ee6ddf845f326802315fec6748f49e7e253d/chrome/browser/prerender/prerender_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment