Changing modality of a window that used to be a system modal. |
|||||
Issue descriptionWhen a window becomes system modal, we call display_root->window_manager_state()->AddSystemModalWindow(window) in WindowTree::SetModal(). When the same window changes modality, we need to notify window_manager_state about the change.
,
Jul 24 2017
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f34d56e2eee09f83935030fba2b6a6942ebde2ba commit f34d56e2eee09f83935030fba2b6a6942ebde2ba Author: Scott Violet <sky@chromium.org> Date: Tue Jul 25 00:29:47 2017 chromeos/mus: process window modality changing to none This wires up system modal changing to none, which was the case that wasn't previously handled. BUG= 697176 TEST=covered by test Change-Id: I3cfcaa46370b40522c3647f689c1262033d3ae66 Reviewed-on: https://chromium-review.googlesource.com/583643 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#489160} [modify] https://crrev.com/f34d56e2eee09f83935030fba2b6a6942ebde2ba/services/ui/ws/modal_window_controller.cc [modify] https://crrev.com/f34d56e2eee09f83935030fba2b6a6942ebde2ba/services/ui/ws/modal_window_controller.h [modify] https://crrev.com/f34d56e2eee09f83935030fba2b6a6942ebde2ba/services/ui/ws/server_window.cc [modify] https://crrev.com/f34d56e2eee09f83935030fba2b6a6942ebde2ba/services/ui/ws/server_window_observer.h [modify] https://crrev.com/f34d56e2eee09f83935030fba2b6a6942ebde2ba/services/ui/ws/window_tree.cc [modify] https://crrev.com/f34d56e2eee09f83935030fba2b6a6942ebde2ba/services/ui/ws/window_tree_unittest.cc
,
Jul 25 2017
,
Feb 26 2018
,
Feb 26 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by moshayedi@chromium.org
, Jun 19 2017Owner: ----