New issue
Advanced search Search tips

Issue 697173 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 697171



Sign in to add a comment

several PageLoadMetricsBrowserTest browser_tests failing under msan

Project Member Reported by thakis@chromium.org, Feb 28 2017

Issue description

https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6001

PageLoadMetricsBrowserTest.BadXhtml
PageLoadMetricsBrowserTest.DocumentWriteBlock
PageLoadMetricsBrowserTest.DocumentWriteReload
PageLoadMetricsBrowserTest.NoDocumentWrite
PageLoadMetricsBrowserTest.NoStatePrefetchObserverCacheable
PageLoadMetricsBrowserTest.NoStatePrefetchObserverNoStore
PageLoadMetricsBrowserTest.PreloadDocumentWrite

Representative stack:

==6831==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x219e4c5 in OnTimingUpdated chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc:113:44
    #1 0x219d680 in DispatchToMethodImpl\u003C(anonymous namespace)::TimingUpdatedObserver *, bool ((anonymous namespace)::TimingUpdatedObserver::*)(const page_load_metrics::PageLoadTiming &, const page_load_metrics::PageLoadMetadata &), const std::__1::tuple\u003Cpage_load_metrics::PageLoadTiming, page_load_metrics::PageLoadMetadata> &, 0, 1> base/tuple.h:91:3
    #2 0x219d680 in DispatchToMethod\u003C(anonymous namespace)::TimingUpdatedObserver *, bool ((anonymous namespace)::TimingUpdatedObserver::*)(const page_load_metrics::PageLoadTiming &, const page_load_metrics::PageLoadMetadata &), const std::__1::tuple\u003Cpage_load_metrics::PageLoadTiming, page_load_metrics::PageLoadMetadata> &> base/tuple.h:98:0
    #3 0x219d680 in DispatchToMethod\u003C(anonymous namespace)::TimingUpdatedObserver, bool ((anonymous namespace)::TimingUpdatedObserver::*)(const page_load_metrics::PageLoadTiming &, const page_load_metrics::PageLoadMetadata &), void, std::__1::tuple\u003Cpage_load_metrics::PageLoadTiming, page_load_metrics::PageLoadMetadata> > ipc/ipc_message_templates.h:26:0
    #4 0x219d680 in Dispatch\u003C(anonymous namespace)::TimingUpdatedObserver, (anonymous namespace)::TimingUpdatedObserver, void, bool ((anonymous namespace)::TimingUpdatedObserver::*)(const page_load_metrics::PageLoadTiming &, const page_load_metrics::PageLoadMetadata &)> ipc/ipc_message_templates.h:121:0
    #5 0x219d680 in OnMessageReceived chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc:94:0
    #6 0x53ebabd in DispatchMessage content/public/browser/browser_message_filter.cc:87:24
    #7 0x53ebabd in OnMessageReceived content/public/browser/browser_message_filter.cc:67:0
    #8 0x10838259 in TryFiltersImpl ipc/message_filter_router.cc:22:21
    #9 0x10838259 in TryFilters ipc/message_filter_router.cc:87:0
    #10 0x107e9b84 in TryFilters ipc/ipc_channel_proxy.cc:87:31
    #11 0x107ea198 in ?? ipc/ipc_channel_proxy.cc:122:8
    #12 0x107dfb35 in OnMessageReceived ipc/ipc_channel_mojo.cc:414:14
    #13 0x107fc55c in Receive ipc/ipc_message_pipe_reader.cc:110:14
    #14 0x4211bbe in Accept /mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/gen/ipc/ipc.mojom.cc:260:13
    #15 0x107fd286 in Accept /mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/gen/ipc/ipc.mojom.h:274:12
    #16 0x103ce732 in HandleValidatedMessage mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:399:32
    #17 0x104197c6 in Accept mojo/public/cpp/bindings/lib/filter_chain.cc:40:17
    #18 0x10808c16 in Accept ipc/ipc_mojo_bootstrap.cc:752:20
    #19 0x104197c6 in Accept mojo/public/cpp/bindings/lib/filter_chain.cc:40:17
    #20 0x103ca490 in ReadSingleMessage mojo/public/cpp/bindings/lib/connector.cc:258:51
    #21 0x103cb359 in ReadAllAvailableMessages mojo/public/cpp/bindings/lib/connector.cc:283:10
    #22 0x103cb359 in OnHandleReadyInternal mojo/public/cpp/bindings/lib/connector.cc:214:0
    #23 0x103cb359 in OnWatcherHandleReady mojo/public/cpp/bindings/lib/connector.cc:192:0
    #24 0x10422dd9 in Run base/callback.h:85:12
    #25 0x10422dd9 in OnHandleReady mojo/public/cpp/system/watcher.cc:87:0
    #26 0xb56b264 in Run base/callback.h:68:12
    #27 0xb56b264 in RunTask base/debug/task_annotator.cc:59:0
    #28 0xb30b6d1 in RunTask base/message_loop/message_loop.cc:423:19
    #29 0xb30d0f1 in DeferOrRunPendingTask base/message_loop/message_loop.cc:434:5
    #30 0xb30ecb5 in DoWork base/message_loop/message_loop.cc:527:13
    #31 0xb320a67 in Run base/message_loop/message_pump_libevent.cc:219:31
    #32 0xb30a739 in RunHandler base/message_loop/message_loop.cc:387:10
    #33 0xb3c0f4c in Run base/run_loop.cc:37:10
    #34 0x57ed984 in IOThreadRun content/browser/browser_thread_impl.cc:277:11
    #35 0x57ee019 in Run content/browser/browser_thread_impl.cc:312:14
    #36 0xb487536 in ThreadMain base/threading/thread.cc:333:3
    #37 0xb4704f5 in ThreadFunc base/threading/platform_thread_posix.cc:71:13
    #38 0x7f79747fb183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0
    #39 0x7f796da8137c in ?? /build/eglibc-oGUzwX/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111:0

  Uninitialized value was stored to memory at
    #0 0x218a968 in AddMatchingFields chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc:67:22
    #1 0x218a968 in RunTestOnMainThread chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc:361:0
    #2 0xb6139a9 in RunTestOnMainThreadLoop chrome/test/base/in_process_browser_test.cc:567:5
    #3 0xd11a18f in ProxyRunTestOnMainThreadLoop content/public/test/browser_test_base.cc:346:5
    #4 0xc79a7ee in Run base/callback.h:85:12
    #5 0xc79a7ee in PreMainMessageLoopRunImpl chrome/browser/chrome_browser_main.cc:1946:0
    #6 0xc795de1 in PreMainMessageLoopRun chrome/browser/chrome_browser_main.cc:1242:18
    #7 0x57a8a64 in PreMainMessageLoopRun content/browser/browser_main_loop.cc:1165:13
    #8 0x6819409 in Run base/callback.h:85:12
    #9 0x6819409 in RunAllTasksNow content/browser/startup_task_runner.cc:45:0
    #10 0x579f2d4 in CreateStartupTasks content/browser/browser_main_loop.cc:973:25
    #11 0x57baa15 in Initialize content/browser/browser_main_runner.cc:125:17
    #12 0x57926a2 in BrowserMain content/browser/browser_main.cc:45:32
    #13 0xb2060a2 in RunNamedProcessTypeMain content/app/content_main_runner.cc:491:14
    #14 0xb208d4e in Run content/app/content_main_runner.cc:836:12
    #15 0xb2011d0 in ContentMain content/app/content_main.cc:20:28
    #16 0xd11911f in SetUp content/public/test/browser_test_base.cc:312:3
    #17 0xb60da6f in SetUp chrome/test/base/in_process_browser_test.cc:258:20
    #18 0xf36d077 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2458:12
    #19 0xf36d077 in Run testing/gtest/src/gtest.cc:2470:0
    #20 0xf370131 in Run testing/gtest/src/gtest.cc:2656:11
    #21 0xf371699 in Run testing/gtest/src/gtest.cc:2774:28
    #22 0xf391bad in RunAllTests testing/gtest/src/gtest.cc:4647:43
    #23 0xf390a1e in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    #24 0xf390a1e in Run testing/gtest/src/gtest.cc:4255:0

  Uninitialized value was created by a heap allocation
    #0 0x79b862 in operator new(unsigned long) ??:?
    #1 0x2188ce0 in CreateTimingUpdatedObserver chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc:173:51
    #2 0x218a221 in RunTestOnMainThread chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc:360:7
    #3 0xb6139a9 in RunTestOnMainThreadLoop chrome/test/base/in_process_browser_test.cc:567:5
    #4 0xd11a18f in ProxyRunTestOnMainThreadLoop content/public/test/browser_test_base.cc:346:5
    #5 0xc79a7ee in Run base/callback.h:85:12
    #6 0xc79a7ee in PreMainMessageLoopRunImpl chrome/browser/chrome_browser_main.cc:1946:0
    #7 0xc795de1 in PreMainMessageLoopRun chrome/browser/chrome_browser_main.cc:1242:18
    #8 0x57a8a64 in PreMainMessageLoopRun content/browser/browser_main_loop.cc:1165:13
    #9 0x6819409 in Run base/callback.h:85:12
    #10 0x6819409 in RunAllTasksNow content/browser/startup_task_runner.cc:45:0
    #11 0x579f2d4 in CreateStartupTasks content/browser/browser_main_loop.cc:973:25
    #12 0x57baa15 in Initialize content/browser/browser_main_runner.cc:125:17
    #13 0x57926a2 in BrowserMain content/browser/browser_main.cc:45:32
    #14 0xb2060a2 in RunNamedProcessTypeMain content/app/content_main_runner.cc:491:14
    #15 0xb208d4e in Run content/app/content_main_runner.cc:836:12
    #16 0xb2011d0 in ContentMain content/app/content_main.cc:20:28
    #17 0xd11911f in SetUp content/public/test/browser_test_base.cc:312:3
    #18 0xb60da6f in SetUp chrome/test/base/in_process_browser_test.cc:258:20
    #19 0xf36d077 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2458:12
    #20 0xf36d077 in Run testing/gtest/src/gtest.cc:2470:0
    #21 0xf370131 in Run testing/gtest/src/gtest.cc:2656:11
    #22 0xf371699 in Run testing/gtest/src/gtest.cc:2774:28
 

Comment 1 by thakis@chromium.org, Feb 28 2017

Owner: thakis@chromium.org
Status: Started (was: Untriaged)
Cc: mattcary@chromium.org
Yep, r451594 is the culprit.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6557cd40deb894148068183e4489ca264043d214

commit 6557cd40deb894148068183e4489ca264043d214
Author: thakis <thakis@chromium.org>
Date: Tue Feb 28 21:36:32 2017

Get PageLoadMetricsBrowserTest passing under msan

https://codereview.chromium.org/2698813005 forgot to initialize a
field it added.

BUG= 697173 

Review-Url: https://codereview.chromium.org/2723623004
Cr-Commit-Position: refs/heads/master@{#453708}

[modify] https://crrev.com/6557cd40deb894148068183e4489ca264043d214/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Status: Fixed (was: Started)
Woot!

Sign in to add a comment