New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697171 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug


Sign in to add a comment

Get Linux MSan bot green again

Project Member Reported by thakis@chromium.org, Feb 28 2017

Issue description

We didn't watch the MSan bot for a while and it's pretty red now: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6001

We should get it back green. Let's use this as a tracking bug, file bugs for everything that's red, and get it back green.

Feel free to grab any blocker and work on it.
 

Comment 1 by thakis@chromium.org, Feb 28 2017

Blockedon: 697172

Comment 2 by thakis@chromium.org, Feb 28 2017

Blockedon: 697173

Comment 3 by thakis@chromium.org, Feb 28 2017

Blockedon: 697174

Comment 4 by thakis@chromium.org, Feb 28 2017

Blockedon: 697177

Comment 5 by thakis@chromium.org, Feb 28 2017

Blockedon: 697178
Filed  bug 697390  for a ChromeOS-only issue.
Blockedon: 697420
Blockedon: 698252
Owner: thakis@chromium.org
Status: Fixed (was: Available)
Most problems fixed; disabled one remoting unit test under msan. Bot is green again!
Blocking: 598859
Blockedon: 710484
Status: Started (was: Fixed)
…and they regressed again.
Blockedon: 710486
Blockedon: 709341
I didn't actually end up blocking the buildbot move on this ... hopefully that's okay.
Links to the last failing build on the memory.full waterfall and the first failing build on the memory waterfall:

https://luci-milo.appspot.com/buildbot/chromium.memory.full/Linux%20MSan%20Tests/7145
https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/0
Cc: danakj@chromium.org fsam...@chromium.org dalecur...@chromium.org
List of currently failing tests that I'm disabling:

in cc_unittests:
GpuImageDecodeCacheTest.AtRasterUsedDirectlyIfSpaceAllows
GpuImageDecodeCacheTest.GetDecodedImageForDraw
GpuImageDecodeCacheTest.GetDecodedImageForDrawAtRasterDecodeMultipleTimes
GpuImageDecodeCacheTest.GetDecodedImageForDrawHigherQuality
GpuImageDecodeCacheTest.GetDecodedImageForDrawLargerScale
GpuImageDecodeCacheTest.GetDecodedImageForDrawNegative
GpuImageDecodeCacheTest.GetLargeScaledDecodedImageForDraw
GpuImageDecodeCacheTest.GetTaskForImageAlreadyDecodedAndLocked
GpuImageDecodeCacheTest.GetTaskForImageAlreadyDecodedNotLocked
GpuImageDecodeCacheTest.GetTaskForImageAlreadyUploaded
GpuImageDecodeCacheTest.GetTaskForImageCanceledGetsNewTask
GpuImageDecodeCacheTest.GetTaskForImageCanceledWhileReffedGetsNewTask
GpuImageDecodeCacheTest.GetTaskForImageDifferentImage
GpuImageDecodeCacheTest.GetTaskForImageHigherQuality
GpuImageDecodeCacheTest.GetTaskForImageLargerScale
GpuImageDecodeCacheTest.GetTaskForImageLargerScaleNoReuse
GpuImageDecodeCacheTest.GetTaskForImageLowerQuality
GpuImageDecodeCacheTest.NoTaskForImageAlreadyFailedDecoding
GpuImageDecodeCacheTest.OrphanedImagesFreeOnReachingZeroRefs
GpuImageDecodeCacheTest.OrphanedZeroRefImagesImmediatelyDeleted
GpuImageDecodeCacheTest.QualityCappedAtMedium
GpuImageDecodeCacheTest.ShouldAggressivelyFreeResources

in browser_tests: 
WebViewTest.Shim_TestFindAPI_findupdate

in media_unittests:
VideoRendererImplTest.DestroyWhileInitializing
patch to disable the tests: https://codereview.chromium.org/2817443004/ . Someone may wish to pick it up and make fixes as needed to land it if it fails to land as-is.
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbacf9f287be8eeb7d208d8abeac67e1534d1b22

commit cbacf9f287be8eeb7d208d8abeac67e1534d1b22
Author: dpranke <dpranke@chromium.org>
Date: Thu Apr 13 10:16:44 2017

Disable tests failing on Linux MSAN tests on chromium.memory.

These tests have been failing for a little while, but since I
just moved the builder onto the chromium.memory waterfall, they
will now be reported to the sheriffs, and so it's better to
disable them until they can be triaged.

TBR=thakis@chromium.org, danakj@chromium.org, fsamuel@chromium.org, dalecurtis@chromium.org
BUG= 697171 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

Review-Url: https://codereview.chromium.org/2817443004
Cr-Commit-Position: refs/heads/master@{#464367}

[modify] https://crrev.com/cbacf9f287be8eeb7d208d8abeac67e1534d1b22/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/cbacf9f287be8eeb7d208d8abeac67e1534d1b22/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/cbacf9f287be8eeb7d208d8abeac67e1534d1b22/media/renderers/video_renderer_impl_unittest.cc

Cc: -danakj@chromium.org ericrk@chromium.org
+ericrk for GpuImageDecodeCacheTest tests being disabled
Blockedon: 711318
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/995002514a6d75ab8065ff7e995ea9e9a1a93951

commit 995002514a6d75ab8065ff7e995ea9e9a1a93951
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Apr 13 16:04:17 2017

Disable another test failing on Linux MSAN tests on chromium.memory

As a follow up to r464367 this conditionally disables
GpuImageDecodeCacheTest.GetTaskForImageCanceledGetsNewTask

TBR=thakis@chromium.org, danakj@chromium.org, fsamuel@chromium.org, dalecurtis@chromium.org
BUG= 697171 , 709341 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2813213003
Cr-Commit-Position: refs/heads/master@{#464425}

[modify] https://crrev.com/995002514a6d75ab8065ff7e995ea9e9a1a93951/cc/tiles/gpu_image_decode_cache_unittest.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cefc60264ab620406f71fdb27e817b406465e94

commit 7cefc60264ab620406f71fdb27e817b406465e94
Author: thakis <thakis@chromium.org>
Date: Thu Apr 13 17:56:05 2017

Update bug numbers of disabled MSan tests.

https://codereview.chromium.org/2817443004/ used a tracking bug as
TODO for various tests failing on MSan. Used one targeted bug per
failing test instead.

BUG= 697171 , 711318 , 709341 ,710486
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=danakj,dalecurtis

Review-Url: https://codereview.chromium.org/2818763002
Cr-Commit-Position: refs/heads/master@{#464463}

[modify] https://crrev.com/7cefc60264ab620406f71fdb27e817b406465e94/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/7cefc60264ab620406f71fdb27e817b406465e94/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/7cefc60264ab620406f71fdb27e817b406465e94/media/renderers/video_renderer_impl_unittest.cc

Status: Fixed (was: Started)
msan has been on the main waterfall for a while now.

Sign in to add a comment