New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR

Blocking:
issue 674593



Sign in to add a comment

Remove VRFrameData#timestamp

Project Member Reported by lunalu@chromium.org, Feb 28 2017

Issue description

Should we include this API in the spec?
 
Cc: bajones@chromium.org
+cc bajones@ since he's the go-to spec guy.

v1.2 of the spec is making big changes, so this might not be relevant?
This was actually recently stripped out of the spec because it wasn't agreed upon what exactly it should represent. We should probably remove it from Blink's IDLs as well.
Cc: meganlindsay@chromium.org
Labels: Proj-VR
Summary: Remove VRFrameData#timestamp (was: Standardize VRFrameData#timestamp? )
A possible patch is here : https://codereview.chromium.org/2736593002/;
Since the spec was updated, I'd like to update the API to the latest spec.

Labels: -Pri-3 M-59 OS-Android Pri-2
Status: Available (was: Untriaged)
Let's get this in for M59.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465

commit f4b1ca9d2d930fad5daaf6291a7a41c2eb141465
Author: shaobo.yan <shaobo.yan@intel.com>
Date: Thu Mar 09 01:13:32 2017

Update API to latest spec : Remove VRFrameData#timestamp
According to latest WebVR Spec, there are several changes. Remove VRFrameData#timestamp is one of them.

BUG= 697167 

Review-Url: https://codereview.chromium.org/2736593002
Cr-Commit-Position: refs/heads/master@{#455619}

[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/device/vr/vr_service.mojom
[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/third_party/WebKit/LayoutTests/external/wpt/webvr/idlharness-expected.txt
[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/third_party/WebKit/LayoutTests/external/wpt/webvr/idlharness.html
[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/third_party/WebKit/LayoutTests/vr/getFrameData_samewithinframe.html
[delete] https://crrev.com/10253f303a50e68dd30f5b1f372d30646366cc2e/third_party/WebKit/LayoutTests/vr/getFrameData_timestamp_updates.html
[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/third_party/WebKit/Source/modules/vr/VRFrameData.cpp
[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/third_party/WebKit/Source/modules/vr/VRFrameData.h
[modify] https://crrev.com/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465/third_party/WebKit/Source/modules/vr/VRFrameData.idl

Labels: VR-OT2
Status: Fixed (was: Available)
Cc: foolip@chromium.org
Components: Blink>WebXR

Sign in to add a comment