presubmit incorrectly rejects CL |
||||||||
Issue descriptionThe CQ doesn't want to land https://codereview.chromium.org/2703633003/ It says: http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/374106 ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: third_party/WebKit/Source/BUILD.gn Missing LGTM from an OWNER for these files: third_party/WebKit/Source/BUILD.gn Yet I lgtm'd that CL, and I'm in WebKit/OWNERS here https://cs.chromium.org/chromium/src/third_party/WebKit/OWNERS?type=cs&q=webkit/owners+package:%5Echromium$&l=6 and WebKit/Source/OWNERS doesn't exist. It's also suspicious that the message gets printed twice.
,
Feb 28 2017
,
Feb 28 2017
There's a bug in the way we're handling per-file rules and the API_OWNERS file. Working on it now ...
,
Mar 1 2017
,
Mar 2 2017
FYI, when I tried "git cl owners", it correctly suggested thakis@ as a potential reviewer. I thought that was funny because it recognized my CL lacked OWNERS approval but it also recognized thakis@ (who already had given an LGTM) would cover the approval...
,
Mar 2 2017
Proposed fix uploaded to https://chromium-review.googlesource.com/c/447962/ .
,
Mar 2 2017
,
Mar 2 2017
,
Mar 2 2017
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/4dc849f802c527ba3b2ba8fd11c91687794692ba commit 4dc849f802c527ba3b2ba8fd11c91687794692ba Author: Dirk Pranke <dpranke@chromium.org> Date: Tue Mar 07 00:26:06 2017 Fix a bug with handling file:// entries in owners. Previously, if an OWNERS file included //foo/API_OWNERS, then the code would get confused and think that it had already read and processed //foo/OWNERS, transferring the contents of the former to the latter. This was wrong. This change fixes the attribution and adds tests to make sure we catch this in the future. R=thakis@chromium.org BUG= 697156 Change-Id: I1f1b846cafac2ad6d792d2dccfce94911e9d15c3 Reviewed-on: https://chromium-review.googlesource.com/447962 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/4dc849f802c527ba3b2ba8fd11c91687794692ba/owners.py [modify] https://crrev.com/4dc849f802c527ba3b2ba8fd11c91687794692ba/tests/owners_unittest.py
,
Mar 7 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dpranke@chromium.org
, Feb 28 2017Status: Assigned (was: Untriaged)