New issue
Advanced search Search tips

Issue 697155 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools: long arrays don't show length as they used to

Project Member Reported by l...@chromium.org, Feb 28 2017

Issue description

Chrome Version: 57.0.2987.54

What steps will reproduce the problem?
(1) Evaluate this in the console
`(new Array(101)).fill(1)`

What is the expected result?
The length '101' should appear in somewhere in the result

What happens instead?
Console just shows the numbers, hard to see the length

Used to show "Array[101]" in Chrome 56

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5

commit eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5
Author: luoe <luoe@chromium.org>
Date: Wed Mar 01 22:11:34 2017

DevTools: restore array lengths for long arrays

After merging the two array formats, all arrays printed in the console had no
length visible in the description. This CL takes array length hints out from the
'Object previews' experiment to address the regression.

BUG= 697155 

Review-Url: https://codereview.chromium.org/2723773003
Cr-Commit-Position: refs/heads/master@{#454061}

[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/console/console-dirxml-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/console/console-format-array-prototype-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/console/console-format-collections-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/console/console-tainted-globals-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-inline-values-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-save-to-temp-var-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/inline-scope-variables-expected.txt
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js
[modify] https://crrev.com/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5/third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css

Comment 2 by l...@chromium.org, Mar 6 2017

Status: Fixed (was: Started)

Sign in to add a comment