New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697153 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Fix ensureInitialized() to retry if the previous attempts failed

Project Member Reported by kapishnikov@chromium.org, Feb 28 2017

Issue description

If ensureInitialized() fails the first time, the second
call to it will do nothing and return without error like it is already initialized. As the result, if a client builds a second Cronet engine, the ensureInitialized() will succeed but the engine fail when the first native call is made; thus masking the root cause of the failure.

We should make sure that if the previous initialization attempts failed, the next attempts should retry and return to the client the real error instead of behaving like the initialization already happened successfully.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdf249c81c06c4e679f4f1bedd1c5c030da029fa

commit fdf249c81c06c4e679f4f1bedd1c5c030da029fa
Author: kapishnikov <kapishnikov@chromium.org>
Date: Tue Feb 28 20:06:19 2017

Fix ensureInitialized() to retry if the previous attempts failed

If ensureInitialized() fails the first time, the second
call to it will do nothing and return right away. This change makes sure
that if the first call failed, the second one retries the initialization.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG= 697153 

Review-Url: https://codereview.chromium.org/2726613002
Cr-Commit-Position: refs/heads/master@{#453681}

[modify] https://crrev.com/fdf249c81c06c4e679f4f1bedd1c5c030da029fa/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java

Status: Fixed (was: Assigned)

Sign in to add a comment