New issue
Advanced search Search tips

Issue 697137 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Standardize MediaElementAudioSourceNode#mediaElement and MediaStreamAudioSourceNode#mediaStream

Project Member Reported by lunalu@chromium.org, Feb 28 2017

Issue description

According to the spec, though we need a mediaElement / mediaStream to create a MediaElementAudioSourceNode / MediaStreamAudioSourceNode, we don't need to include them in the interface. 

Can someone please confirm that the spec makes sense? If so, I would like to remove them in Blink.
 

Comment 1 by rtoy@chromium.org, Feb 28 2017

I think you're right; we don't need these attributes.

Comment 2 by lunalu@chromium.org, Feb 28 2017

Owner: lunalu@chromium.org
Status: Assigned (was: Untriaged)
So I'd like to remove these. 

Comment 3 by rtoy@chromium.org, Feb 28 2017

On the other hand, it's really kind of useful to expose what element the MediaElementAudioSourceNode is attached to.

I ask the spec on whether this should be exposed.
Cc: foolip@chromium.org

Comment 6 by rtoy@chromium.org, Mar 16 2017

https://github.com/WebAudio/web-audio-api/issues/1157 resolved to add these attributes.

I'll close this when the pull request for the spec change has landed.

Comment 7 by foolip@chromium.org, Mar 30 2017

Summary: Standardize MediaElementAudioSourceNode#mediaElement and MediaStreamAudioSourceNode#mediaStream (was: Remove MediaElementAudioSourceNode#mediaElement and MediaStreamAudioSourceNode#mediaStream)
Owner: rtoy@chromium.org

Comment 9 by foolip@chromium.org, Apr 13 2017

Status: Fixed (was: Assigned)
Fixed in https://github.com/WebAudio/web-audio-api/pull/1201

Comment 10 by rtoy@chromium.org, Apr 18 2017

Status: Assigned (was: Fixed)
Reopening.  As suggested by foolip@, the attributes have [SameObject].  We need to implement this.

Comment 11 by rtoy@chromium.org, Apr 19 2017

Status: Started (was: Assigned)

Comment 12 by rtoy@chromium.org, Apr 21 2017

Status: Fixed (was: Started)
Due to a typo, this wasn't updated with the CL that fixes this.

The CL is https://codereview.chromium.org/2825113002/
Thanks for taking care of this!

Sign in to add a comment