New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697134 link

Starred by 1 user
Status: Assigned
Owner:
thomasanderson@chromium.org
Cc:
█ pam@chromium.org
dbeam@chromium.org
est...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Md-settings supervised user should not have the option to enable/disable the Gtk theme

Project Member Reported by thomasanderson@chromium.org, Feb 28 2017 
Chrome Version: ToT build
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Enable md-settings from chrome:flags if it's not enabled already
(2) Create a supervised user browser window
(3) Open settings

There should be no option to enable the GTK theme for supervised users.  Please see the attached images for clarification.
Screenshot from 2017-02-28 10:53:38.png
184 KB View Download
Screenshot from 2017-02-28 10:55:35.png
134 KB View Download

Comment 1 by dbeam@chromium.org, Feb 28 2017

Cc: -thomasanderson@chromium.org
Labels: Hotlist-MD-Settings-Appearance
Owner: thomasanderson@chromium.org
Status: Assigned (was: Available)
yeah, i fixed this once in  bug 655948  but I guess it somehow regressed (as I see you found in: https://bugs.chromium.org/p/chromium/issues/detail?id=694154#c5)

I think there's another open bug about this somewhere but I didn't find it.

I just tried a bunch of stuff locally and wasn't able to reproduce.  thomasanderson@: can you tweak your repro steps and re-assign to me when you've narrowed down what's happening here?
2017-02-28-112623_946x1366_scrot.png
123 KB View Download
2017-02-28-112704_940x1356_scrot.png
141 KB View Download

Comment 2 by thomasanderson@chromium.org, May 1 2017

Cc: thomasanderson@chromium.org
Owner: dbeam@chromium.org
attached video repro

dbeam: I think disallowing the gtk theme for supervised users is not the right approach.  (users can install extension themes to change the appearance anyway)

I'm guessing this behavior was added so that the tabstrip renders with the blue background by default?  If so, it would make more sense to disable the gtk theme by default rather than remove the option entirely, right?
md_settings_gtk_option.mp4
1.8 MB View Download

Comment 3 by dbeam@chromium.org, May 1 2017

Cc: pam@chromium.org
ok, if you can get a stakeholder from the supervised users team to say that's OK, it's fine by me.

Comment 4 by dbeam@chromium.org, May 4 2017

Cc: -thomasanderson@chromium.org
Owner: thomasanderson@chromium.org
►

Sign in to add a comment