New issue
Advanced search Search tips

Issue 697128 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Bug



Sign in to add a comment

Ensure that Chromoting components do not ship code licensed under [L]GPL.

Project Member Reported by lambroslambrou@chromium.org, Feb 28 2017

Issue description

Need an automated check to prevent Chrome Remote Desktop from shipping with GPL or LGPL licensed components on Android and iOS.
Currently, the Android client lists some [L]GPL components in its Credits file (because they are present in a Chromium checkout), though it doesn't actually ship them.

 
Related:
bug 178215 - Only list code shipped with each platform in about:credits
bug 469261 - License presubmit tests
 bug 486158  - Sort out WebView's OSS licenses checking

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeec4d330e053262b28e1559f2c052206aad3aad

commit aeec4d330e053262b28e1559f2c052206aad3aad
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Mon Mar 06 20:22:06 2017

[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.

BUG=697128,178215

Review-Url: https://codereview.chromium.org/2728913002
Cr-Commit-Position: refs/heads/master@{#454936}

[modify] https://crrev.com/aeec4d330e053262b28e1559f2c052206aad3aad/remoting/android/BUILD.gn
[add] https://crrev.com/aeec4d330e053262b28e1559f2c052206aad3aad/remoting/credits/credits.tmpl
[add] https://crrev.com/aeec4d330e053262b28e1559f2c052206aad3aad/remoting/credits/credits_css.css
[add] https://crrev.com/aeec4d330e053262b28e1559f2c052206aad3aad/remoting/credits/credits_entry.tmpl
[add] https://crrev.com/aeec4d330e053262b28e1559f2c052206aad3aad/remoting/credits/credits_js.js

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5910889b1aa6e3775eb7cb9539dc096e16050aa0

commit 5910889b1aa6e3775eb7cb9539dc096e16050aa0
Author: amineer <amineer@chromium.org>
Date: Tue Mar 07 17:31:48 2017

Revert of [remoting android] Generate trimmed-down credits.html. (patchset #2 id:20001 of https://codereview.chromium.org/2728913002/ )

Reason for revert:
Breaks Android official builds

BUG=699088

Original issue's description:
> [remoting android] Generate trimmed-down credits.html.
>
> This copies resources to a central location, so that the Android build
> is independent of anything under remoting/webapp.
>
> This provides GN options to tools/licenses.py to only list third-party
> projects that are included in the app (currently the "remoting_apk"
> target, but followup work will enable us to specify the actual target
> for Official builds).
>
> Also stripped out CSS rules that were only meaningful for the webapp.
>
>
> BUG=697128,178215
>
> Review-Url: https://codereview.chromium.org/2728913002
> Cr-Commit-Position: refs/heads/master@{#454936}
> Committed: https://chromium.googlesource.com/chromium/src/+/aeec4d330e053262b28e1559f2c052206aad3aad

TBR=jamiewalch@chromium.org,nicholss@chromium.org,lambroslambrou@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=697128,178215

Review-Url: https://codereview.chromium.org/2733153003
Cr-Commit-Position: refs/heads/master@{#455118}

[modify] https://crrev.com/5910889b1aa6e3775eb7cb9539dc096e16050aa0/remoting/android/BUILD.gn
[delete] https://crrev.com/406eb9a4cce877003ea00c22be552b1794b248e9/remoting/credits/credits.tmpl
[delete] https://crrev.com/406eb9a4cce877003ea00c22be552b1794b248e9/remoting/credits/credits_css.css
[delete] https://crrev.com/406eb9a4cce877003ea00c22be552b1794b248e9/remoting/credits/credits_entry.tmpl
[delete] https://crrev.com/406eb9a4cce877003ea00c22be552b1794b248e9/remoting/credits/credits_js.js

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7703f4bb5c3bed162c3e7c753e731f8f2816aa39

commit 7703f4bb5c3bed162c3e7c753e731f8f2816aa39
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Wed Mar 08 23:05:56 2017

[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.

This also updates tools/licenses.py to use GN from //buildtools to
address a previous breakage on official Android builders.

BUG=697128,178215,699088

Review-Url: https://codereview.chromium.org/2728913002
Cr-Commit-Position: refs/heads/master@{#455578}

[modify] https://crrev.com/7703f4bb5c3bed162c3e7c753e731f8f2816aa39/remoting/android/BUILD.gn
[add] https://crrev.com/7703f4bb5c3bed162c3e7c753e731f8f2816aa39/remoting/credits/credits.tmpl
[add] https://crrev.com/7703f4bb5c3bed162c3e7c753e731f8f2816aa39/remoting/credits/credits_css.css
[add] https://crrev.com/7703f4bb5c3bed162c3e7c753e731f8f2816aa39/remoting/credits/credits_entry.tmpl
[add] https://crrev.com/7703f4bb5c3bed162c3e7c753e731f8f2816aa39/remoting/credits/credits_js.js
[modify] https://crrev.com/7703f4bb5c3bed162c3e7c753e731f8f2816aa39/tools/licenses.py

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/3b73964887eb8ec24d4557c474d354fd06b2f5f1

commit 3b73964887eb8ec24d4557c474d354fd06b2f5f1
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Thu Mar 30 17:15:52 2017

Sign in to add a comment