New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697119 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Break on OOM has a lot of false positives

Project Member Reported by alph@chromium.org, Feb 28 2017

Issue description

Steps to reproduce:

1. Open theverge.com
2. Open DevTools #1
3. Open DevTools #2 on DevTools #1
4. Take heap snapshot of theverge in DevTools #1
5. Breaks occur several times during snapshotting despite the memory usage is just tens of MBs.

 
Cc: u...@chromium.org
Ulan, could it be related to worker case with http://www.findyourwaytooz.com/ which we debugged during BlinkOn ?

Comment 2 by u...@chromium.org, Mar 1 2017

Cc: -u...@chromium.org kozyatinskiy@chromium.org
Owner: u...@chromium.org
I'll take a look.

Comment 4 by u...@chromium.org, Mar 6 2017

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.

Comment 6 by u...@chromium.org, Mar 7 2017

Labels: -Merge-TBD Merge-Request-58
We can merge after getting canary coverage.
Cc: hablich@chromium.org
+hablich@ for M58 merge review
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
We are planning to cut Dev RC today (03/08) at 5.00 PM PST. Please merge the CL to M58 branch (3029) ASAP.
Please merge your change to M58 branch 3029 before 5:00 PM PT, Monday (03/13/17) so we can take it in for next week dev release. Thank you!

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 13 2017

Labels: merge-merged-5.8
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f3243e920a18ab5fc9a96e392a499ff06ed5a224

commit f3243e920a18ab5fc9a96e392a499ff06ed5a224
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Mon Mar 13 08:58:18 2017

Merged: [heap] Do not delay mark-compact by doing scavenge.

Revision: af55a29706703121f83837d0c9020649bb9ec6ce

BUG= chromium:697119 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org

Review-Url: https://codereview.chromium.org/2750463002 .
Cr-Commit-Position: refs/branch-heads/5.8@{#25}
Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1}
Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429}

[modify] https://crrev.com/f3243e920a18ab5fc9a96e392a499ff06ed5a224/src/heap/heap.cc

Project Member

Comment 12 by sheriffbot@chromium.org, Mar 13 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by u...@chromium.org, Mar 13 2017

Labels: -Merge-Approved-58
If there is no pending work, can we tag this as fixed?

Comment 15 by u...@chromium.org, Mar 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment