Remove Client#frameType |
||||||
Issue descriptionThe spec for Client has been changed. We should remove frameType. See https://github.com/slightlyoff/ServiceWorker/issues/732#issuecomment-235898697 Also, we should add "readonly attribute ClientType type;" to the interface, for more details, please see the spec: https://w3c.github.io/ServiceWorker/#client
,
Mar 17 2017
FYI: Firefox hasn't removed this yet[1] because of a privacy issue on an alternative feature (ancestorOrigins)[2] [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1290936 [2] https://github.com/w3c/ServiceWorker/issues/732#issuecomment-280060084
,
Mar 17 2017
ancestorOrigins issue is part of it. Its also that we prefer chrome to take the lead on breaking changes like this because developers are less likely to test their SW in firefox.
,
Mar 20 2017
,
Mar 21 2017
Also we need to implement the alternative feature WindowClient#ancestorOrigins before removing frameType.
,
Mar 21 2017
Adding use counter is a good first step though.
,
Mar 21 2017
Is there a bug for those ancestorOrigins changes that this can be blocked on?
,
Mar 21 2017
,
Mar 21 2017
Done :)
,
Mar 27 2017
Although this issue's title is focused on the `frameType` attribute, the description includes a suggestion to implement the `type` attribute. I'm suggesting we track each change separately--see issue 705685 .
,
Mar 31 2017
Issue 707347 has been merged into this issue.
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56151ab64d017acbe7de93c40e7b72374704e83a commit 56151ab64d017acbe7de93c40e7b72374704e83a Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Jun 29 03:07:59 2017 service worker: Add UseCounter for Client#frameType This feature is at-risk and we need to measure the usage. Bug: 697110 Change-Id: Iaee645f8037ebd3b7b28ec8e0ba0b3f774115653 Reviewed-on: https://chromium-review.googlesource.com/554040 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#483275} [add] https://crrev.com/56151ab64d017acbe7de93c40e7b72374704e83a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/feature-worker.js [modify] https://crrev.com/56151ab64d017acbe7de93c40e7b72374704e83a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/usecounter.html [modify] https://crrev.com/56151ab64d017acbe7de93c40e7b72374704e83a/third_party/WebKit/Source/modules/serviceworkers/Client.idl [modify] https://crrev.com/56151ab64d017acbe7de93c40e7b72374704e83a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp [modify] https://crrev.com/56151ab64d017acbe7de93c40e7b72374704e83a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp [modify] https://crrev.com/56151ab64d017acbe7de93c40e7b72374704e83a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h [modify] https://crrev.com/56151ab64d017acbe7de93c40e7b72374704e83a/third_party/WebKit/public/platform/WebFeature.h [modify] https://crrev.com/56151ab64d017acbe7de93c40e7b72374704e83a/tools/metrics/histograms/enums.xml
,
Mar 3 2018
,
Dec 19
Client#frameType is back: https://github.com/w3c/ServiceWorker/pull/1329 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by foolip@chromium.org
, Mar 9 2017