New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697099 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ChromeOS full-screen mis-renders the tab-strip

Project Member Reported by w...@chromium.org, Feb 28 2017

Issue description

Chrome Version: 58.0.3015.0 canary (64-bit)
OS: ChromeOS

What steps will reproduce the problem?
[0] I have a "theme" installed; not sure if that's required.
(1) Open several tabs.
(2) Press the full-screen button.
(3) Move the mouse to the top of the screen, to show the tab strip.

What is the expected result?

Expect that the tab strip looks correctly rendered.

What happens instead?

Instead it has a sort of phantom rendering of some of the tab headers (see screenshot)

 
Screenshot 2017-02-28 at 09.13.35.png
97.9 KB View Download

Comment 1 by warx@chromium.org, Mar 2 2017

Cc: sky@chromium.org
I have seen something similar recently as the attachment. Issue is not seen on emulator build.


Screenshot 2017-03-02 at 11.53.03 AM.png
79.9 KB View Download

Comment 2 by warx@chromium.org, Mar 2 2017

btw, the above screenshot is taken on veyron_minnie 58.0.3029.0, 9286.0.0

Comment 3 by sky@chromium.org, Mar 2 2017

My guess is we aren't a repaint with the correct bounds.

Comment 4 by warx@chromium.org, Mar 3 2017

Cc: jamescook@chromium.org est...@chromium.org
Labels: has-Bisect
bisect shows the culprit CL is: https://codereview.chromium.org/2674813002.

I don't know how to fix it yet. Since original CL indicates BUG=NONE, I am going to revert it since it causes significant UI change to users.

Comment 5 by warx@chromium.org, Mar 3 2017

Cc: pkotw...@chromium.org

Comment 6 by warx@chromium.org, Mar 6 2017

Cc: bhthompson@chromium.org abodenha@chromium.org
Labels: ReleaseBlock-Stable
I believe this should be RBS for M-58.
Agreed. Definitely RBS. Thanks for flagging and bisecting.

Probably best to chat with estade@ before reverting.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2aafec33859883cdd69a43b301a40a79ce9327

commit bc2aafec33859883cdd69a43b301a40a79ce9327
Author: warx <warx@chromium.org>
Date: Mon Mar 06 18:30:46 2017

cros: Fix immersive fullscreen tabstrip revealing does not draw well

Changes:
When OnImmersiveRevealStarted(), if top container's layer is not marked as not filling bounds opaquely, the tabstrip may not draw correctly. It happens when user has theme installed or hovers mouse onto tabstrip.

Regression comes from: https://codereview.chromium.org/2674813002.

BUG= 697099 
TEST=device test bug does not happen

Review-Url: https://codereview.chromium.org/2728063002
Cr-Commit-Position: refs/heads/master@{#454896}

[modify] https://crrev.com/bc2aafec33859883cdd69a43b301a40a79ce9327/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/bc2aafec33859883cdd69a43b301a40a79ce9327/ui/views/controls/label.cc

Comment 9 by warx@chromium.org, Mar 6 2017

Labels: Merge-Request-58
The #8 CL is pretty safe to be merged.
merge sgtm
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 7 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8d551ee7fd1e0621d9b6aeaf40d60c98729e8f9

commit a8d551ee7fd1e0621d9b6aeaf40d60c98729e8f9
Author: Qiang Xu <warx@chromium.org>
Date: Tue Mar 07 19:50:45 2017

[Merge to M58] cros: Fix immersive fullscreen tabstrip revealing does not draw well

Changes:
When OnImmersiveRevealStarted(), if top container's layer is not marked as not filling bounds opaquely, the tabstrip may not draw correctly. It happens when user has theme installed or hovers mouse onto tabstrip.

Regression comes from: https://codereview.chromium.org/2674813002.

TBR=pkotwicz@chromium.org, sky@chromium.org, estade@chromium.org
BUG= 697099 
TEST=device test bug does not happen

Review-Url: https://codereview.chromium.org/2728063002
Cr-Commit-Position: refs/heads/master@{#454896}
(cherry picked from commit bc2aafec33859883cdd69a43b301a40a79ce9327)

Review-Url: https://codereview.chromium.org/2740463003 .
Cr-Commit-Position: refs/branch-heads/3029@{#49}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/a8d551ee7fd1e0621d9b6aeaf40d60c98729e8f9/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/a8d551ee7fd1e0621d9b6aeaf40d60c98729e8f9/ui/views/controls/label.cc

Comment 13 by warx@chromium.org, Mar 7 2017

Status: Fixed (was: Assigned)

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment