New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697096 link

Starred by 2 users
Status: WontFix
Owner:
█ emx@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
msarda@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

No branded string for Chromium for User Manager string

Project Member Reported by jasonkliu@chromium.org, Feb 28 2017 
Chrome Version: (copy from chrome://version) 56.0.2898.0 
OS: (e.g. Win7, OSX 10.9.5, etc...) 10.12.3

What steps will reproduce the problem?
(1) Go to chrome://settings/
(2) Scroll down to People section

What is the expected result?
"Let anyone add a person to Chromium"

What happens instead?
"Let anyone add a person to Chrome"


See attached image.
Screen Shot 2017-02-28 at 9.13.03 AM.png
53.4 KB View Download

Comment 2 by a...@chromium.org, Feb 28 2017

Labels: -OS-Mac OS-All
Owner: mlerman@chromium.org
Status: Assigned (was: Untriaged)
Summary: No branded string for Chromium for User Manager string (was: No branded string for Chromium)
mlerman:

In https://codereview.chromium.org/709593003 you changed IDS_PROFILE_ADD_PERSON_ENABLE to be a branded string. You need to split it into branded/unbranded.

Comment 3 by mlerman@chromium.org, Feb 28 2017

Owner: msarda@chromium.org
Whoops, my bad!
Sadly, I left the team a while ago.

Assigning to Mihai.

Comment 4 Deleted

Comment 5 Deleted

Comment 6 by msarda@chromium.org, Mar 28 2017

Cc: msarda@chromium.org
Owner: emx@chromium.org

Comment 7 by emx@chromium.org, Mar 30 2017 

In v59.0.3056.0 the new MD settings UI is the default and it does not include this string. The string is still in the code, but there is probably little point in fixing this now.

Comment 8 by emx@chromium.org, Mar 30 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment