New issue
Advanced search Search tips

Issue 697092 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 401588



Sign in to add a comment

Make cloud_print/virtual_driver/win/install/BUILD.gn not set output_dir = "$root_gen_dir/virtual_driver_setup_resources"

Project Member Reported by thakis@chromium.org, Feb 28 2017

Issue description

cloud_print/virtual_driver/win/install/BUILD.gn currently has

  output_dir = "$root_gen_dir/virtual_driver_setup_resources"


https://codereview.chromium.org/2714393004/ made that target use  `use_qualified_include = true` which means that grd file's .h file is now included via

#include "virtual_driver_setup_resources/grit/virtual_driver_setup_resources.h"


This means cloud_print/DEPS needs an entry like

 "+virtual_driver_setup_resources",

referring to a top-level dir that doesn't really exist.

Using the default output dir nicely makes grit outputs match the existing DEPS system.


So if possible cloud_print should not override that output_dir.
 
Status: Fixed (was: Untriaged)

Sign in to add a comment