Make cloud_print/virtual_driver/win/install/BUILD.gn not set output_dir = "$root_gen_dir/virtual_driver_setup_resources" |
||
Issue descriptioncloud_print/virtual_driver/win/install/BUILD.gn currently has output_dir = "$root_gen_dir/virtual_driver_setup_resources" https://codereview.chromium.org/2714393004/ made that target use `use_qualified_include = true` which means that grd file's .h file is now included via #include "virtual_driver_setup_resources/grit/virtual_driver_setup_resources.h" This means cloud_print/DEPS needs an entry like "+virtual_driver_setup_resources", referring to a top-level dir that doesn't really exist. Using the default output dir nicely makes grit outputs match the existing DEPS system. So if possible cloud_print should not override that output_dir.
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2454074759e99af48bc0e5042d2faac816e97790 commit 2454074759e99af48bc0e5042d2faac816e97790 Author: pastarmovj <pastarmovj@chromium.org> Date: Mon Mar 13 10:42:11 2017 Clean up after https://codereview.chromium.org/2741633003/. BUG= 697092 TBR=thakis Review-Url: https://codereview.chromium.org/2748633002 Cr-Commit-Position: refs/heads/master@{#456349} [modify] https://crrev.com/2454074759e99af48bc0e5042d2faac816e97790/cloud_print/virtual_driver/win/install/BUILD.gn
,
Mar 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 10 2017