StyledLabel doesn't have bottom border |
||||||
Issue descriptionStyledLabel is used for a text "Chrome will..." for Password generation pop-up. It doesn't have bottom label (screenshots attached).
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2581d91a5a2adfdae460bd25a43b44cac6f80ded commit 2581d91a5a2adfdae460bd25a43b44cac6f80ded Author: dvadym <dvadym@chromium.org> Date: Wed Mar 08 18:24:05 2017 Add bottom border to StyledLabel. On CL https://codereview.chromium.org/2072513003 it was changed calculation of height of StyledLabel, so the |total_height| is equal to the bottom point of lowest sublabel. This doesn't take into consideration a bottom border. Screenshots are on the bug. This CL fixes this. BUG= 697034 Review-Url: https://codereview.chromium.org/2722503005 Cr-Commit-Position: refs/heads/master@{#455495} [modify] https://crrev.com/2581d91a5a2adfdae460bd25a43b44cac6f80ded/ui/views/controls/styled_label.cc [modify] https://crrev.com/2581d91a5a2adfdae460bd25a43b44cac6f80ded/ui/views/controls/styled_label_unittest.cc
,
Mar 10 2017
This is a small bug fix.
,
Mar 10 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 10 2017
Your change is approved for M58. Please merge ASAP so that it will be picked up for next Dev release.
,
Mar 12 2017
Please merge your change to M58 branch 3029 before 5:00 PM PT, Monday (03/13/17) so we can take it in for next week dev release. Thank you!
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be0be00087150bd7c26414bcd3898c83e241fd7c commit be0be00087150bd7c26414bcd3898c83e241fd7c Author: Vadym Doroshenko <dvadym@chromium.org> Date: Mon Mar 13 10:55:44 2017 [Merge to M-58]Add bottom border to StyledLabel. On CL https://codereview.chromium.org/2072513003 it was changed calculation of height of StyledLabel, so the |total_height| is equal to the bottom point of lowest sublabel. This doesn't take into consideration a bottom border. Screenshots are on the bug. This CL fixes this. BUG= 697034 Review-Url: https://codereview.chromium.org/2722503005 Cr-Commit-Position: refs/heads/master@{#455495} (cherry picked from commit 2581d91a5a2adfdae460bd25a43b44cac6f80ded) Review-Url: https://codereview.chromium.org/2742303002 . Cr-Commit-Position: refs/branch-heads/3029@{#144} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/be0be00087150bd7c26414bcd3898c83e241fd7c/ui/views/controls/styled_label.cc [modify] https://crrev.com/be0be00087150bd7c26414bcd3898c83e241fd7c/ui/views/controls/styled_label_unittest.cc
,
Mar 13 2017
,
Mar 14 2017
Verified this issue on Windows 10 and Ubuntu 14.04 using chrome version#58.0.3029.19 Observed the styledlabel has a bottom border. Attaching a screen-cast for reference. Hence adding TE-Verified labels. Thank You... |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kolos@chromium.org
, Mar 8 2017