New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697024 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

When RenderFrameHost is destroyed, should the mojo interfaces be destroyed?

Project Member Reported by zqzh...@chromium.org, Feb 28 2017

Issue description

Got this issue from http://crbug.com/695398.

So basically MediaSessionServiceImpl is a mojo service created by RenderFrameHostImpl. However in some situations it can still receive message after the RenderFrameHostImpl is destroyed.

Before the fix of that bug, MediaSessionServiceImpl assumes it will be destroyed when RFH is destroyed, so it's safe to store a raw pointer of RFH. However the assumption was wrong, and MediaSessionServiceImpl can outlive RFH.

I assume RFHImpl::InvalidateMojoConnection() should have done all the tear down for mojo services, but it does not.

dcheng@, can you take a look?
 
Cc: roc...@chromium.org
Status: Assigned (was: Untriaged)
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment