New issue
Advanced search Search tips

Issue 696996 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.5%-4.2% regression in webrtc_perf_tests at 16779:16779

Project Member Reported by terelius@chromium.org, Feb 28 2017

Issue description

Clear change in the performance metrics seems to coincide with introducing the new PlatformThread constructor.
 

Comment 2 by tommi@chromium.org, Mar 1 2017

Cc: holmer@chromium.org
Stefan, Bjorn - I need your help to understand what these changes really mean :)

From what I can tell, the difference seems to be that the change introduced in my CL, removes a call to sched_yield() that was implicitly there, and uses only the done_.Wait(kSendStatsPollingIntervalMs) check that was already in PollStats().
See here:

https://codereview.webrtc.org/2708723003/diff/80001/webrtc/video/video_quality_test.cc?context=50

Looking at the perf data from the bots, I don't see the "cpu_usage" field being recorded, but I do see that locally and there seems to be a slight improvement there, not a regression.

As far as 'encode_usage_percent' goes, there appears to be an improvement for foreman_cif_30kbps_net_delay_0_0_plr_0 whereas there's a regression for foreman_cif_500kbps_32pkts_queue.

Are these tests perhaps very sensitive to when exactly the stats are polled?
Cc: asapersson@chromium.org
They could be sensitive, but I don't know for sure, Åsa probably knows better.

Comment 4 by tommi@chromium.org, Jul 18 2017

Status: WontFix (was: Assigned)

Sign in to add a comment