New issue
Advanced search Search tips

Issue 696992 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.3%-11.9% regression in webrtc_perf_tests at 16848:16848

Project Member Reported by terelius@chromium.org, Feb 28 2017

Issue description

Increased cpu usage after chromium roll.
 
Cc: -terelius@chromium.org
Labels: OS-Mac
Owner: terelius@chromium.org
It indeed seems the roll is causing this problem.
Can you try this?
1. run webrtc_perf_tests  on your machine. Make note of the value of one of the metrics showing up here.
2. Revert the Clang roll locally, essentially by just:
cd src/tools
git revert edfe48e975a7549b3eb79407a1b0f4daab64cdbe
3. gclient sync
4. compile
5. Re-run webrtc_perf_tests and compare the metric noted in 1.

Does it still regress? Then it's not the Clang roll that caused this. I think we should find that out before proceeding.
Owner: kjellander@chromium.org
I've tried what you suggested, but I'm unable to say anything interesting. The metrics in the bug are from H264 on Mac, and the H264 tests don't appear to be running at all on my Linux machine. Is there a way to force them to run?

The encode times in some other tests have changed slightly, but it is impossible to tell whether that is a real change or just random variation. Note that the difference in the bug is small as well; for example the encode usage increased from 20.2% to 20.7% in foreman_cif_delay_50_0_plr_5_H264.
Owner: terelius@chromium.org
Since this regression only happens on Mac you have to run it on a Mac.

I checked the graphs all the way up to today's date and it seems the regression is still around, but I leaning towards accepting that one and close this bug. 
I'll leave that decision to you though - you might want to check with someone like holmer@ before closing it. 

Sign in to add a comment