New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696966 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 695626
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Text/Fonts blink is observed on Time Setting overlay after toggle the button for ‘CaretTab’ extension

Reported by dmascare...@etouch.net, Feb 28 2017

Issue description

Chrome Version:58.0.3026.0 (Official Build) fe586ab75aca1b8ab839db23bceac5f621389fed-refs/heads/master@{#453454} 32/64-bit.
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1).

Pre-condition: Add ‘CaretTab extension using url: https://chrome.google.com/webstore/detail/carettab-new-tab-page/cojpndognjdcakkimaloeealehpkljna?utm_source=chrome-ntp-icon

What steps will reproduce the problem?
1. Launch chrome and navigate to New tab, click on setting icon present at bottom right of window.
2. Time Setting overlay gets open, then click on first toggle button or hover on ‘Search Google’ field of Tab and observe.

Actual: Text/Fonts blinks after step 2.
Expected: Text/fonts should not blink.

This is regression issue, broken in ‘M 58’ and below is manual bisect:
Good build:58.0.3008.0
Bad build:58.0.3010.0
 
Actual_time.mov
1.6 MB Download
Exp.mov
2.0 MB Download
Cc: fmalita@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: bunge...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build -- 58.0.3008.0 (revision : 449509)
Bad Build  -- 58.0.3010.0 (revision : 449855)

You are probably looking for a change made after 449849 (known good), but no later than 449850 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/f1965acd5e67a8c7d5b537bb56dbbc5733ba7a67..8eaad28b5cb7f0386f0f38c227dbc359111a3d5b

Suspecting the following Commit from above CL --
https://skia.googlesource.com/skia.git/+/a67615f370c15ed0dd7a7ca95c9f73178e3e2499

@bungeman -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Cc: bunge...@chromium.org
Labels: -Pri-1 Pri-2
Owner: bsalomon@chromium.org
So the issue that the lighter text in the "Time Settings" panel becomes brighter while the animation is running. Note that https://skia.googlesource.com/skia.git/+/a67615f370c15ed0dd7a7ca95c9f73178e3e2499 can only affect Windows, and the .mov files were captured on a Mac, so this CL is not the issue.

It rather looks like something the text might be drawn as white with transparency and we're calculating the transparency differently because something something changed in the layer structure during the animation.

The only two changes in that Skia roll that look like they could affect this are bsalomon's and fmalita's changes.
Mergedinto: 695626
Status: Duplicate (was: Assigned)

Sign in to add a comment