New issue
Advanced search Search tips

Issue 696922 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebLocalFrameImpl::setFindEndstateFocusAndSelection should not call FrameSeleciton::setSelction with valid node

Project Member Reported by falken@chromium.org, Feb 28 2017 
Chrome Version: ToT 58.0.3027.0 with DCHECK enabled
OS: Linux

What steps will reproduce the problem?
(1) Open any page, e.g., https://en.wikipedia.org/wiki/Help:Editing
(2) Find in Page (Ctrl+F) -> input something on the page (e.g., "simple")
(3) Wait for simple to be highlighted in the page.
(4) Reload the page (Ctrl+R)

What is the expected result?

Page reloads.

What happens instead?

Renderer crash.

Please use labels and text to provide additional information.

Suspect "Make FrameSelection to hold non-canonicalized DOM positions"
https://crrev.com/d892f9592860691ae9a782c12260c94ed6bd1a63

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by falken@chromium.org, Feb 28 2017 

#0 0x7f3e03c59197 base::debug::StackTrace::StackTrace()
#1 0x7f3e03c58d0f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f3e03de2330 <unknown>
#3 0x7f3dfa30dc37 gsignal
#4 0x7f3dfa311028 abort
#5 0x7f3e03c56e02 base::debug::BreakDebugger()
#6 0x7f3e03c7d842 logging::LogMessage::~LogMessage()
#7 0x7f3df5b6b4eb blink::SelectionTemplate<>::assertValidFor()
#8 0x7f3df5b4a022 blink::FrameSelection::setSelectionDeprecated()
#9 0x7f3df5b49f34 blink::FrameSelection::setSelection()
#10 0x7f3dfd7748ed blink::WebLocalFrameImpl::setFindEndstateFocusAndSelection()
#11 0x7f3dfd776398 blink::WebLocalFrameImpl::stopFinding()
#12 0x7f3e019e3033 _ZN3IPC8MessageTI25FrameMsg_StopFinding_MetaSt5tupleIJN7content14StopFindActionEEEvE8DispatchINS3_15RenderFrameImplES8_vMS8_FvS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#13 0x7f3e019d6b1c content::RenderFrameImpl::OnMessageReceived()
#14 0x7f3e040b65c6 IPC::MessageRouter::RouteMessage()
#15 0x7f3e040b649a IPC::MessageRouter::OnMessageReceived()
#16 0x7f3e00f9a4b8 content::ChildThreadImpl::OnMessageReceived()

Comment 2 by yosin@chromium.org, Feb 28 2017

Owner: ----
Status: Available (was: Untriaged)
We should update layout in WebLocalFrameImpl::setFindEndstateFocusAndSelection() before calling FrameSelection::setSeleciton()

Comment 3 by yosin@chromium.org, Feb 28 2017

Summary: WebLocalFrameImpl::setFindEndstateFocusAndSelection should update layout before FrameSelection::setSelection (was: Assert failure in blink::SelectionTemplate<>::assertValidFor())

Comment 4 by yosin@chromium.org, Feb 28 2017

Summary: WebLocalFrameImpl::setFindEndstateFocusAndSelection should not call FrameSeleciton::setSelction with valid node (was: WebLocalFrameImpl::setFindEndstateFocusAndSelection should update layout before FrameSelection::setSelection)
#c2 is false. It seems WebLocalFrameImpl::setFindEndstateFocusAndSelection() passed invalid position.

Comment 5 by yosin@chromium.org, Oct 4 2017

Labels: Pri-3
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 4

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by yosin@chromium.org, Oct 5

Status: Available (was: Untriaged)
►

Sign in to add a comment