RenderWidgetHostViewChildFrameTest.SwapCompositorFrame is failing |
|||||
Issue descriptioncontent_unittests failing on 2 builders Builders failed on: - Win 7 Tests x64 (1): https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29 - Win10 Tests x64: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64 According to tzik, RenderWidgetHostViewChildFrameTest needs to have some scoped member to avoid this crash.
,
Feb 28 2017
Stacktrace: Backtrace: base::PostTaskWithTraits [0x0000000141CB6E59+57] content::RenderWidgetHostImpl::RenderWidgetHostImpl [0x0000000140CE5EE6+1030] content::RenderWidgetHostViewChildFrameTest::SetUp [0x0000000140090B85+197] testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x0000000141AD52DD+61] testing::Test::Run [0x0000000141AE0A8A+74] testing::TestInfo::Run [0x0000000141AE0CB1+161] testing::TestCase::Run [0x0000000141AE0B95+165] testing::internal::UnitTestImpl::RunAllTests [0x0000000141AE1062+562] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0000000141AD537D+61] testing::UnitTest::Run [0x0000000141AE0DF9+217] base::TestSuite::Run [0x00000001415FDA89+137] base::LaunchUnitTests [0x00000001415FB060+1040] base::LaunchUnitTests [0x00000001415FACB7+103] main [0x00000001406E4DD1+133] __scrt_common_main_seh [0x0000000142F5A369+285] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253) BaseThreadInitThunk [0x00000000779F59CD+13] RtlUserThreadStart [0x0000000077B2B891+33]
,
Feb 28 2017
,
Feb 28 2017
Disabling: https://codereview.chromium.org/2720993002
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df2e35bcb196be8aad241b8b465b22e09573f61d commit df2e35bcb196be8aad241b8b465b22e09573f61d Author: yutak <yutak@chromium.org> Date: Tue Feb 28 09:00:37 2017 Disable RenderWidgetHostViewChildFrameTest.SwapCompositorFrame on Windows. BUG= 696919 TBR=fsamuel@chromium.org,sergeyu@chromium.org,dvadym@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2720993002 Cr-Commit-Position: refs/heads/master@{#453547} [modify] https://crrev.com/df2e35bcb196be8aad241b8b465b22e09573f61d/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
,
Feb 28 2017
Adding some more people. Marking as P2 since this might mean broken OOPIFs.
,
Feb 28 2017
tzik@ has a CL in progress to fix the test (thanks!): https://codereview.chromium.org/2720163003/ Let's get this re-enabled as soon as we can, because Fady's right that we don't want regressions to OOPIF behavior to sneak in. Ken thinks this particular case is just a test issue, thankfully.
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da781ffa872f659a8f0de9a20b4166789a3f5409 commit da781ffa872f659a8f0de9a20b4166789a3f5409 Author: sergeyu <sergeyu@chromium.org> Date: Tue Feb 28 19:55:00 2017 Disable RenderWidgetHostViewChildFrameTest.VisibilityTest on windows. The test fails sometimes: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/8763 BUG= 696919 TBR=fsamuel@chromium.org,yutak@chromium.org,dvadym@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2720333002 Cr-Commit-Position: refs/heads/master@{#453678} [modify] https://crrev.com/da781ffa872f659a8f0de9a20b4166789a3f5409/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
,
Mar 1 2017
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25937f56120530c2662a3a0b2e3ed7a2a3103ed4 commit 25937f56120530c2662a3a0b2e3ed7a2a3103ed4 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Mar 20 10:00:22 2017 Disable RenderWidgetHostViewChildFrameTest.FrameEvictionKeepsLocalSurfaceId on Win BUG= 696919 TBR=tzik@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2761723002 . Cr-Commit-Position: refs/heads/master@{#458031} [modify] https://crrev.com/25937f56120530c2662a3a0b2e3ed7a2a3103ed4/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25937f56120530c2662a3a0b2e3ed7a2a3103ed4 commit 25937f56120530c2662a3a0b2e3ed7a2a3103ed4 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Mar 20 10:00:22 2017 Disable RenderWidgetHostViewChildFrameTest.FrameEvictionKeepsLocalSurfaceId on Win BUG= 696919 TBR=tzik@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2761723002 . Cr-Commit-Position: refs/heads/master@{#458031} [modify] https://crrev.com/25937f56120530c2662a3a0b2e3ed7a2a3103ed4/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d6c4a51e01d9f6d37e24b1964bb482421808b73 commit 5d6c4a51e01d9f6d37e24b1964bb482421808b73 Author: tzik <tzik@chromium.org> Date: Fri Mar 31 15:53:43 2017 Add missing TaskScheduler on tests using RendereWidgetHostImpl RenderWidgetHostImpl constructor requires an instance of TaskScheduler on Windows. Its absence causes DCHECK failure or null ptr access failure only on Windows, which is hard to find for non-windows devs. This CL adds a DCHECK to detect it on non-Windows build, so that we notice the failure earlier, and also fixes the failure detected by the DCHECK. BUG= 696919 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2785883004 Cr-Commit-Position: refs/heads/master@{#461134} [modify] https://crrev.com/5d6c4a51e01d9f6d37e24b1964bb482421808b73/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc [modify] https://crrev.com/5d6c4a51e01d9f6d37e24b1964bb482421808b73/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/5d6c4a51e01d9f6d37e24b1964bb482421808b73/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm [modify] https://crrev.com/5d6c4a51e01d9f6d37e24b1964bb482421808b73/content/browser/renderer_host/text_input_client_mac_unittest.mm
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e4cfb7160d81365035e927a8a1b63676f718e9e commit 3e4cfb7160d81365035e927a8a1b63676f718e9e Author: tzik <tzik@chromium.org> Date: Fri Mar 31 16:13:36 2017 Enable disabled RenderWidgetHostViewChildFrameTest These tests should not fail after http://crrev.com/2785883004. BUG= 696919 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2785193003 Cr-Commit-Position: refs/heads/master@{#461139} [modify] https://crrev.com/3e4cfb7160d81365035e927a8a1b63676f718e9e/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
,
Mar 31 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yutak@chromium.org
, Feb 28 2017