New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696896 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

'Action menu' of added exception remains open after clicking on Edit in chrome://md-settings

Reported by jshan...@etouch.net, Feb 28 2017

Issue description

Chrome Version: 58.0.3025.6 6c1332290fc0f9c3b59345fde8c6476367c31395-refs/branch-heads/3025@{#9}
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

Steps:
1. Launch Chrome and navigate to chrome://md-settings/content/cookies
2. Add exception in 'Block/Allow/Clear on exit' and click on 'Action menu' against it
3. Select 'Edit' option from Action menu and observe

Actual: 'Action menu' of added exception remains open after clicking on Edit

Expected: 'Action menu' of added exception should close after clicking on Edit

This is a non-regression issue, seen from M-58 series as this is new feature introduced in build # 58.0.3022.0


 
Actual_video.mp4
636 KB View Download
Status: Untriaged (was: Unconfirmed)
Changing the status to Untriaged, so that the issue would get addressed.
Thank You.
Cc: tbuck...@chromium.org dbeam@chromium.org
I don't think this is a problem. The action menu is closed along with the dialog.

@dbeam, tbuckley: WDYT?
Cc: dpa...@chromium.org

Comment 4 by dbeam@chromium.org, Mar 1 2017

Labels: -Pri-2 -M-58 Pri-3
Status: Available (was: Untriaged)
ideally, we would close the action menu when "Edit" is clicked (and before/while the "Edit exception" dialog is showing)
Labels: -Pri-3 Hotlist-MD-Settings-Privacy-SiteSettings Pri-2
Owner: dpa...@chromium.org
Status: Assigned (was: Available)
Agreed.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9070600ab8f23e9f7d7dc468173157388d56769

commit d9070600ab8f23e9f7d7dc468173157388d56769
Author: dpapad <dpapad@chromium.org>
Date: Tue Mar 07 22:25:51 2017

MD Settings: Close action menu when opening edit cookie exception dialog.

BUG= 696896 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2739693002
Cr-Commit-Position: refs/heads/master@{#455253}

[modify] https://crrev.com/d9070600ab8f23e9f7d7dc468173157388d56769/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/d9070600ab8f23e9f7d7dc468173157388d56769/chrome/test/data/webui/settings/site_list_tests.js

Status: Fixed (was: Started)

Sign in to add a comment