Issue metadata
Sign in to add a comment
|
Regresion : Unnecessarily cursor appears in omnibox after clicking inside the 'Search box' on NTP.
Reported by
yfulgaon...@etouch.net,
Feb 28 2017
|
||||||||||||||||||||||
Issue descriptionChrome version : 58.0.3025.6 (Official Build) 6c1332290fc0f9c3b59345fde8c6476367c31395-refs/branch-heads/3025@{#9} 32/64 bit OS : Windows (7,8,10), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, open NTP and click inside the 'Search box'. 2. Observe the cursor in omnibox and 'Search box'. Actual : Unnecessarily cursor appears in omnibox after clicking inside the 'Search box' on NTP (i.e both the cursors are seen at the same time) Expected : Instead, the cursor should be seen only in the 'Search box' after clicking inside it and cursor should vanish from the omnibox. This is a regression issue broken in ‘M-58’, below is the Manual Regression range and will soon update other info. Good build : 58.0.3014.0 Bad build : 58.0.3015.0 Note : 1. Above issue is reproducible on Windows (7,8,8.1,10), Linux (14.04 LTS) OS and it is working fine on Mac (10.11.6, 10.12.1, 10.12) OS. 2. Issue is also seen in #58.0.3026.0 build.
,
Feb 28 2017
,
Feb 28 2017
,
Feb 28 2017
I have tried and it is caused by my changes. I am looking into fixing now.
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/413ab9af7d2755e3287b07b08c21fc3be062103c commit 413ab9af7d2755e3287b07b08c21fc3be062103c Author: yiyix <yiyix@chromium.org> Date: Thu Mar 02 02:00:21 2017 Remove the unnecessarily cursor appeared in omnibox after clicking inside the 'Search box' BUG= 696894 Review-Url: https://codereview.chromium.org/2728433002 Cr-Commit-Position: refs/heads/master@{#454148} [modify] https://crrev.com/413ab9af7d2755e3287b07b08c21fc3be062103c/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/413ab9af7d2755e3287b07b08c21fc3be062103c/ui/views/controls/textfield/textfield_test_api.h [modify] https://crrev.com/413ab9af7d2755e3287b07b08c21fc3be062103c/ui/views/controls/textfield/textfield_unittest.cc
,
Mar 2 2017
,
Mar 2 2017
This bug requires manual review: We don't branch M58 until 2017-03-02. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 6 2017
,
Mar 6 2017
M58 (3029) is branched at chromium revision #454471. Cl listed at #5 landed before the branch so no merge is needed here.
,
Mar 7 2017
Verified the fix on the latest M-58(58.0.3029.6) on Windows-10 and Linux Ubuntu 14.04. This is working as intended and cursor is seen only inside the omnibox or inside the NTP search box when clicked. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Feb 28 2017Owner: yiyix@chromium.org
Status: Assigned (was: Unconfirmed)