New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696879 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 693583
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Codesearch index is incorrect for parts of src/cc

Project Member Reported by pdr@chromium.org, Feb 28 2017

Issue description

The codesearch index is incorrect for parts of src/cc. For example, search for callsites of SetCurrentlyScrollingLayer and click the first callsite (LayerTreeHostImpl::ScrollBegin):
https://cs.chromium.org/chromium/src/cc/trees/layer_tree_impl.cc?type=cs&q=LayerTreeImpl::SetCurrentlyScrollingLayer&l=644

The resulting line number will be incorrect in layer_tree_host_impl.cc
 
Mergedinto: 693583
Status: Duplicate (was: Untriaged)
The xrefs are about 7 hours behind at the moment (http://shortn/_pXLZ1RA7VD), which sucks, but is normal.

Comment 3 by emso@chromium.org, Feb 28 2017

Yes, a drawback from the Git integration. Could we do something a bit more clever on our side? 

We currently run the gen builder, upload the index pack, and then the indexing pipeline is run. Is it an option to have more builders and to let them overlap, e.g., with two builders start one each 2 hours, alternating between the two and so on for more. Not sure about the time of the Kythe pipeline or if that could be run in parallel. If not in parallel, we could try to make sure it is not idle by feeding it a fresh index pack as soon as it's done. 

On the other end, I recall discussing patching of locations to adjust for this problem. I can investigate this with the Kythe team.

Thoughts?

Sign in to add a comment