New issue
Advanced search Search tips

Issue 696859 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 571533


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Use `constexpr` for constants in Page Info code.

Project Member Reported by lgar...@chromium.org, Feb 28 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b8d28d3b852d8e881082efc3c08bde3077b416

commit 07b8d28d3b852d8e881082efc3c08bde3077b416
Author: Patricia Lor <patricialor@chromium.org>
Date: Fri Oct 13 00:46:36 2017

Desktop Page Info/Mac: Don't immediately remove permissions set back to default.

Using Page Info to update permissions back to the factory default setting on Mac
will immediately remove them from the bubble. This might be annoying since users
may not expect this and may have mistakenly selected the wrong setting, in which
case they would have to open Site Details to change it again (or wait for
another prompt).

Match the behaviour on Views and don't remove the permission until the Page Info
bubble has been closed.

Manual test - On Mac, Navigate to https://permission.site. Click "Notifications"
button and click "Block" when the prompt shows up. Then click "USB", select a
device and click "Connect" (USB devices can be added manually at
chrome://usb-internals/). Open the Page Info bubble by clicking the icon to the
left of the Omnibox. Verify it has an entry for "Notifications" and the name of
the USB device chosen earlier. Change the "Notifications" entry to
"Ask (default)", and verify it does not disappear and the USB entry is still
there, and that pressing tab will cycle through all the focusable elements in
Page Info. Then click the "x" next to the USB device and verify it disappears.
Verify pressing tab to cycle through all the focusable elements in Page Info
still works.

Bug:  772769 ,  695690 ,  696859 
Change-Id: I3cf61b6598dd4deceb4d87f79f31e3541507dcda
Reviewed-on: https://chromium-review.googlesource.com/706446
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508570}
[modify] https://crrev.com/07b8d28d3b852d8e881082efc3c08bde3077b416/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
[modify] https://crrev.com/07b8d28d3b852d8e881082efc3c08bde3077b416/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/07b8d28d3b852d8e881082efc3c08bde3077b416/chrome/browser/ui/cocoa/page_info/permission_selector_button.h
[modify] https://crrev.com/07b8d28d3b852d8e881082efc3c08bde3077b416/chrome/browser/ui/cocoa/page_info/permission_selector_button.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f5551413e03f5ebc31555ab0eacf12e4e76d30f

commit 6f5551413e03f5ebc31555ab0eacf12e4e76d30f
Author: Patti <patricialor@chromium.org>
Date: Wed Oct 25 03:25:01 2017

Desktop Page Info/Views/Harmony: Clean up padding, sizing, & alignment.

Remove a bunch of custom defined whitespace constants used in the Views Page
Info bubble and replace them with LayoutProvider metrics in preparation for
Harmony. Also clean up a bunch of icon alignment, inconsistent text sizes and
padding issues. This patch also moves the permissions and chosen objects above
the separator line.

See screenshots at
https://drive.google.com/file/d/0BzEa5HU1aAqBb0NGM0V4OUVtRTg/view?usp=sharing
including Harmony and non-Harmony changes.

Bug:  535074 ,  696859 
Change-Id: Idc51c81fc7bb462ded76639162425297dda1d89e
Reviewed-on: https://chromium-review.googlesource.com/711534
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511350}
[modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/chosen_object_row.cc
[modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/chosen_object_row.h
[modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
[modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/permission_selector_row.cc
[modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/permission_selector_row.h

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 4 by est...@chromium.org, Nov 30 2017

Owner: patricia...@chromium.org
Status: Assigned (was: Available)
Patti do you know if there's more work to do here?

Comment 5 by est...@chromium.org, Nov 30 2017

Labels: Hotlist-GoodFirstBug
Status: Fixed (was: Assigned)
Nope, with Harmony the constants are mostly all gone and the remaining few are all constexpr. Thanks for pinging on this! Closing.

Sign in to add a comment