Issue metadata
Sign in to add a comment
|
Use `constexpr` for constants in Page Info code. |
||||||||||||||||||||||
Issue description
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f5551413e03f5ebc31555ab0eacf12e4e76d30f commit 6f5551413e03f5ebc31555ab0eacf12e4e76d30f Author: Patti <patricialor@chromium.org> Date: Wed Oct 25 03:25:01 2017 Desktop Page Info/Views/Harmony: Clean up padding, sizing, & alignment. Remove a bunch of custom defined whitespace constants used in the Views Page Info bubble and replace them with LayoutProvider metrics in preparation for Harmony. Also clean up a bunch of icon alignment, inconsistent text sizes and padding issues. This patch also moves the permissions and chosen objects above the separator line. See screenshots at https://drive.google.com/file/d/0BzEa5HU1aAqBb0NGM0V4OUVtRTg/view?usp=sharing including Harmony and non-Harmony changes. Bug: 535074 , 696859 Change-Id: Idc51c81fc7bb462ded76639162425297dda1d89e Reviewed-on: https://chromium-review.googlesource.com/711534 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#511350} [modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/chosen_object_row.cc [modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/chosen_object_row.h [modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/page_info_bubble_view.cc [modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/page_info_bubble_view.h [modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc [modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/permission_selector_row.cc [modify] https://crrev.com/6f5551413e03f5ebc31555ab0eacf12e4e76d30f/chrome/browser/ui/views/page_info/permission_selector_row.h
,
Nov 10 2017
,
Nov 30 2017
Patti do you know if there's more work to do here?
,
Nov 30 2017
,
Dec 4 2017
Nope, with Harmony the constants are mostly all gone and the remaining few are all constexpr. Thanks for pinging on this! Closing. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 13 2017