New issue
Advanced search Search tips

Issue 696857 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 696881



Sign in to add a comment

17.3%-59.3% regression in media.tough_video_cases at 450502:451268 [idle wake-ups]

Project Member Reported by tguilbert@chromium.org, Feb 28 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=696857

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghIupqgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghNOGtAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxMCXoQsM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac11-air
chromium-rel-mac12
Summary: 17.3%-59.3% regression in media.tough_video_cases at 450502:451268 [idle wake-ups] (was: 17.3%-59.3% regression in media.tough_video_cases at 450502:451268)
Labels: media_regression_2_27
Blocking: 696881
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Feb 28 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: mac_10_12_perf_bisect
  Benchmark    : media.tough_video_cases
  Metric       : idle_wakeups_total/idle_wakeups_total

Revision             Result                  N
chromium@450501      1368.35 +- 99.6192      21      good
chromium@450572      1359.21 +- 123.305      20      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests media.tough_video_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8986450841734965040

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5910435368271872


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Feb 28 2017

Cc: ccameron@chromium.org
Owner: ccameron@chromium.org

=== Auto-CCing suspected CL author ccameron@chromium.org ===

Hi ccameron@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : ccameron
  Commit : 3b6fe6da979b8d9e084160ce6d8b7bd83f3aa878
  Date   : Fri Feb 17 06:21:58 2017
  Subject: color: Don't use QCMS for transforms unless necessary

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : media.tough_video_cases
  Metric       : idle_wakeups_browser/video.html?src_tulip2.webm
  Change       : 28.50% | 688.333333333 -> 884.5

Revision             Result                  N
chromium@451156      688.333 +- 51.5493      6      good
chromium@451205      698.333 +- 33.9608      6      good
chromium@451229      651.333 +- 163.583      6      good
chromium@451241      695.333 +- 34.7467      6      good
chromium@451243      639.667 +- 203.89       6      good
chromium@451244      863.167 +- 61.4559      6      bad       <--
chromium@451247      887.5 +- 87.9062        6      bad
chromium@451253      884.5 +- 27.5953        6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.tulip2.webm media.tough_video_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8986387439069205856

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5908069311053824


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: crouleau@chromium.org
Status: Assigned (was: Untriaged)
Hey ccameron@, could you please investigate and resolve this? Is it expected that idle_wakeups would increase after your change?
Owner: ----
Status: Available (was: Assigned)
My patch should not be affecting media playback.
Also, the graphs appear to have mostly returned to their original levels.
Status: WontFix (was: Available)
Marking as WontFix (or, a bit more accurately fix-unknown).
Spoke offline with ccameron@. While we agree that his change was the culprit, we suspect that this is caused by "something about the layout of the binary or some unrelated effect". It would be good for us to at some point iron these out.... The graph looks like it was really just returning to normal with his change anyway.

Sign in to add a comment