Minor issue: Sheriff-o-Matic comment feature post comment delay |
|||
Issue descriptionA very minor issue from my android chrome build sheriff experience. Feel free to ignore Sheriff-o-Matic comment feature has somewhat of a delay between pressing enter and showing the comment And if I press enter multiple times, it would post comment multiple times cause the comment to show up multiple times
,
Feb 28 2017
The comment is posted after an ajax request response, so that's where the delay comes from. I think the best way to solve this would be to disable the comment submissions until a response is received. Alternatively, we could also/instead have the UI show the comment as having already been posted before confirmation is received, but this is a modern UX pattern that I have a lot of mixed feelings about.
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/65d36829e1ca1a7bdfbea00897ee36892f05fd1c commit 65d36829e1ca1a7bdfbea00897ee36892f05fd1c Author: Tiff Zhang <zhangtiff@google.com> Date: Fri Mar 03 23:41:43 2017 SoM: Show when comments are in flight. BUG= 696847 Change-Id: I8eb505dd14c220e576e7647ecf83803723572ad1 Reviewed-on: https://chromium-review.googlesource.com/448099 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> [modify] https://crrev.com/65d36829e1ca1a7bdfbea00897ee36892f05fd1c/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations/som-annotations.html [modify] https://crrev.com/65d36829e1ca1a7bdfbea00897ee36892f05fd1c/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations/som-annotations.js
,
Mar 3 2017
This should be fixed and out with the next deployment (Tuesday). Feel free to file a new bug if followup is required. |
|||
►
Sign in to add a comment |
|||
Comment 1 by martiniss@chromium.org
, Feb 28 2017Status: Available (was: Untriaged)