New issue
Advanced search Search tips

Issue 696831 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
dcheng@chromium.org
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Should we use int or size_t in editing function?

Project Member Reported by yabinh@chromium.org, Feb 28 2017 
Currently we are switching between int and size_t in the call stack of editing functions. e.g., for deleteSurroundingText(), we use int in RenderFrameImpl, and size_t in RenderFrameHostImpl.

This issue was raised in a CL review: 
https://codereview.chromium.org/2617443002/#msg97

Comment 1 by yosin@chromium.org, Feb 28 2017

Status: Available (was: Untriaged)
We have another option to use |unsigned|, since core/dom uses |unsigned| for length and offset, e.g. CharacterData::length(), insertData(), etc.

Although, the spec says they should be |unsigned long long| (uint64_t).

I remembered WebKit decide to use |unsigned| instead of |size_t| since there are few or no usage need |uint64_t| in real website on 2014?

However, I'm not sure current decision.
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by yosin@chromium.org, Mar 20 2018

Status: Available (was: Untriaged)
►

Sign in to add a comment