New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 696830 link

Starred by 1 user
Status: Fixed
Owner:
█ dim...@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

When a new downloaded page is added to Download Home, it's impossible to delete it until DH is refreshed

Project Member Reported by dim...@chromium.org, Feb 28 2017 
1. Open Download Home
2. In other tab, open some page with links
3. Long-press -> Download Link, observe a page to download and appear in Download Home
4. Try to delete the page just downloaded via selection and pressing Delete button

Observe - page is not deleted, selection removed.
Expected: page deleted.

Once Download Home is refreshed or closed/opened, the page can be deleted.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/335b9f4cc30ccbeeb8c40e3ad6b7435a73af9a6a

commit 335b9f4cc30ccbeeb8c40e3ad6b7435a73af9a6a
Author: dimich <dimich@chromium.org>
Date: Tue Feb 28 22:08:32 2017

Fix the inability to delete just-downloaded pages from Download Home.

This happens because Offline Page is initially created w/o file path, which becomes known when the OfflinePageDownloadItem is updated in the process of download. We need to update mFilePathsToItemsMap map which is used during deletion to find all the items using the same file path.

BUG= 696830 

Review-Url: https://codereview.chromium.org/2721803002
Cr-Commit-Position: refs/heads/master@{#453719}

[modify] https://crrev.com/335b9f4cc30ccbeeb8c40e3ad6b7435a73af9a6a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

Comment 2 by dim...@chromium.org, Mar 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment