presubmit warning to run "git cl format --js" in wrong directory or with no visible error |
||
Issue descriptionI have a CL with changes in src/chrome/browser/resources/settings/controls/ and src/ui/webui/resources/cr_elements/ Presubmit warns: > The resources directory requires source formatting. Please run > git cl format --js ui/webui/resources But running that does nothing. Running `git cl format --js` does fix an issue in a changed src/chrome file. But after fixing that, presubmit continues printing the above warning.
,
Feb 28 2017
The presubmit just runs git cl format --js --dry-run and checks the return code. You can run git cl format --js --diff to see what git cl format thinks is wrong?
,
Feb 28 2017
note that there was a recent regression in `git cl format --diff` that was fixed only 1-2h ago. make sure to `gclient sync` first.
,
Feb 28 2017
Yep, it was returning some binary junk. After `gclient sync` it works normally again. |
||
►
Sign in to add a comment |
||
Comment 1 by michae...@chromium.org
, Feb 28 2017