New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696821 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-04-20
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[History] Delete non-MD History WebUI

Project Member Reported by tsergeant@chromium.org, Feb 28 2017

Issue description

Once Native History has shipped on Android, and Grouped History has shipped for supervised users, there will be no remaining usage of the old WebUI code at c/b/r/history, allowing it to be deleted!

We are currently targeting early M60 to delete the code.
 

Comment 1 by dbeam@chromium.org, Apr 20 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25b548f921b2eb2e255ddb3fe5b7e40c556e4363

commit 25b548f921b2eb2e255ddb3fe5b7e40c556e4363
Author: dbeam <dbeam@chromium.org>
Date: Fri May 05 18:05:24 2017

Remove old webui History page on desktop and mobile

This CL also drops a few features and flags relating to enabling:

1) native history on Android
2) material design history on desktop
3) grouped history (was not ported to MD history)

and generally audits strings and resources and stuff.

R=twellington@chromium.org
BUG= 696821 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2830983005
Cr-Commit-Position: refs/heads/master@{#469716}

[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/android/java_sources.gni
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/android/javatests/src/org/chromium/chrome/browser/HistoryUITest.java
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/about_flags.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/android/data_usage/data_use_ui_tab_model.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/android/data_usage/data_use_ui_tab_model_unittest.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/android/ntp/new_tab_page_url_handler.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/browser_about_handler.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/browser_about_handler_unittest.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/browser_resources.grd
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/history/history_browsertest.cc
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/2x/disclosure_triangle_small.png
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/disclosure_triangle_small.png
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/OWNERS
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/alert_overlay.css
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/alert_overlay.html
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/compiled_resources2.gyp
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/externs.js
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/history.css
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/history.html
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/history.js
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/history_focus_manager.js
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/history_mobile.css
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/other_devices.css
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/history/other_devices.js
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/resources/md_history/externs.js
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/ssl/images/2x/roadblock.png
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/resources/ssl/images/roadblock.png
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/resources/uber/uber.html
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/resources/uber/uber_frame.html
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/resources/uber/uber_frame.js
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/sessions/better_session_restore_browsertest.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/sessions/chrome_serialized_navigation_driver.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/sessions/chrome_serialized_navigation_driver_unittest.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/browser_navigator_browsertest.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
[add] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/history_ui.cc
[add] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/history_ui.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/browsing_history_handler_unittest.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/history_login_handler.cc
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/ui/webui/history_ui.cc
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/browser/ui/webui/history_ui.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/md_history_ui.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/uber/uber_ui.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/uber/uber_ui.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/browser/ui/webui/uber/uber_ui_browsertest.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/common/chrome_features.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/common/chrome_features.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/common/chrome_switches.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/common/chrome_switches.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/common/url_constants.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/common/url_constants.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/test/data/webui/BUILD.gn
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/chrome/test/data/webui/history_browsertest.js
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/test/data/webui/history_ui_browsertest.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/test/data/webui/history_ui_browsertest.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/chrome/test/data/webui/md_history/md_history_browsertest.js
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/components/history_strings.grdp
[rename] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/components/sync/driver/resources/star_small.png
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/components/sync/driver/resources/sync_node_browser.css
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/content/public/common/content_features.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/content/public/common/content_features.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/ios/chrome/browser/browser_about_rewriter.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/ios/chrome/browser/chrome_switches.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/ios/chrome/browser/chrome_switches.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/ios/chrome/browser/chrome_url_constants.cc
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/ios/chrome/browser/chrome_url_constants.h
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/25b548f921b2eb2e255ddb3fe5b7e40c556e4363/third_party/closure_compiler/compiled_resources2.gyp
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/ui/webui/resources/images/2x/search.png
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/ui/webui/resources/images/2x/x-thin.png
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/ui/webui/resources/images/laptop.svg
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/ui/webui/resources/images/smartphone.svg
[delete] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/ui/webui/resources/images/tablet.svg

Comment 3 by dbeam@chromium.org, Jun 2 2017

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1491949b8d61c0e56eb388c786c8a974cf79f405

commit 1491949b8d61c0e56eb388c786c8a974cf79f405
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Jun 08 04:51:46 2018

Remove history_ui.cc.

This CL removes the old HistoryUI file and moves the icon retrieval
functionality to the ChromeWebUIControllerFactory.

Bug:  696821 
Change-Id: I198c44bbfa86bd3b56cac01f3ecaa3f38254f285
Reviewed-on: https://chromium-review.googlesource.com/1069963
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565534}
[modify] https://crrev.com/1491949b8d61c0e56eb388c786c8a974cf79f405/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/d1de178223cdc465037bfe5e480d1499ee3be610/chrome/browser/ui/history_ui.cc
[delete] https://crrev.com/d1de178223cdc465037bfe5e480d1499ee3be610/chrome/browser/ui/history_ui.h
[modify] https://crrev.com/1491949b8d61c0e56eb388c786c8a974cf79f405/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Sign in to add a comment