New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696815 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 690070



Sign in to add a comment

Disable SDCH by Default

Project Member Reported by rsleevi@chromium.org, Feb 28 2017

Issue description

This is the technical tracking bug for launch bug Issue 690070
 
Disable SDCH by default across the product. Embedders - whether Cronet or //content embedders - will be able to enable it, until we can reach broader internal consensus to fully remove the code.

See also https://groups.google.com/a/chromium.org/d/msg/blink-dev/nQl0ORHy7sw/HNpR96sqAgAJ
Blocking: 690070
Cc: rsleevi@chromium.org mariakho...@chromium.org
 Issue 687182  has been merged into this issue.
Labels: -M-58 M-59
Moving to M59 due to bad interactions with the cache.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4152e1751a735f2c0f2cffc30976f9c5ed233f95

commit 4152e1751a735f2c0f2cffc30976f9c5ed233f95
Author: rdsmith <rdsmith@chromium.org>
Date: Fri Mar 31 12:29:44 2017

Disable SDCH by Default

Disable SDCH in Chrome. It remains accessible via either explicit
initialization of an SdchManager/SdchOwner or through the use of
URLRequestContextBuilder's set_sdch_enabled(true)

This does not disable the SDCH netlog panel, as there may be SDCH net-internals dumps that need to be examined from earlier versions of Chrome.

BUG= 696815 

patch from issue 2720613006 at patchset 1 (http://crrev.com/2720613006#ps1)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2785493003
Cr-Commit-Position: refs/heads/master@{#461100}

[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/browser/net/sdch_browsertest.cc
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/browser/resources/net_internals/sdch_view.js
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/common/chrome_constants.cc
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/common/chrome_constants.h
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/test/data/webui/net_internals/log_util.js
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/chrome/test/data/webui/net_internals/sdch_view.js
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.h
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.h
[modify] https://crrev.com/4152e1751a735f2c0f2cffc30976f9c5ed233f95/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

Owner: rdsmith@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment