Most, if not all Physical Web tests use instrumentation, even though most (if not all) do not need to. We should migrate them from javatests/ to junit/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/701a03d7ed45254fb5dba4f89c6fc7e990cadde5 commit 701a03d7ed45254fb5dba4f89c6fc7e990cadde5 Author: cco3 <cco3@chromium.org> Date: Tue Feb 28 18:37:30 2017 Move UrlInfoTest to junit UrlInfoTest does not need to be an instrumentation test, so this change moves it from javatests/ to junit/. BUG= 696804 Review-Url: https://codereview.chromium.org/2725523002 Cr-Commit-Position: refs/heads/master@{#453648} [modify] https://crrev.com/701a03d7ed45254fb5dba4f89c6fc7e990cadde5/chrome/android/java_sources.gni [rename] https://crrev.com/701a03d7ed45254fb5dba4f89c6fc7e990cadde5/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7004210ac90b797a1dce103dcfb70bf1675add9 commit a7004210ac90b797a1dce103dcfb70bf1675add9 Author: cco3 <cco3@chromium.org> Date: Wed Mar 01 03:09:53 2017 Move PwsClientImplTest to junit PwsClientImplTest does not need to be an instrumentation test, so this change moves it from javatests/ to junit/. In order to ease testing, this change also removes the constructor parameter from PwsClientImpl. BUG= 696804 Review-Url: https://codereview.chromium.org/2721083002 Cr-Commit-Position: refs/heads/master@{#453811} [modify] https://crrev.com/a7004210ac90b797a1dce103dcfb70bf1675add9/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClientImpl.java [modify] https://crrev.com/a7004210ac90b797a1dce103dcfb70bf1675add9/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/a7004210ac90b797a1dce103dcfb70bf1675add9/chrome/android/java_sources.gni [rename] https://crrev.com/a7004210ac90b797a1dce103dcfb70bf1675add9/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/PwsClientImplTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/104f81845c1906da368d74c20e4b161a348c0567 commit 104f81845c1906da368d74c20e4b161a348c0567 Author: cco3 <cco3@chromium.org> Date: Thu Mar 02 20:29:45 2017 Move PwsResultTest to junit PwsResultTest does not need to be an instrumentation test, so this change moves it from javatests/ to junit/. BUG= 696804 Review-Url: https://codereview.chromium.org/2722623003 Cr-Commit-Position: refs/heads/master@{#454363} [modify] https://crrev.com/104f81845c1906da368d74c20e4b161a348c0567/chrome/android/java_sources.gni [delete] https://crrev.com/612c5c49898c0766cd07f65f95bc930e98210ef6/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/PwsResultTest.java [add] https://crrev.com/104f81845c1906da368d74c20e4b161a348c0567/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/PwsResultTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbb4ab906568a80aa3e7a314e6570cc3b8900777 commit cbb4ab906568a80aa3e7a314e6570cc3b8900777 Author: cco3 <cco3@chromium.org> Date: Tue Mar 14 20:10:16 2017 Move UrlManagerTest to junit UrlManagerTest does not need to be an instrumentation test, so this change moves it from javatests/ to junit/. BUG= 696804 Review-Url: https://codereview.chromium.org/2723783003 Cr-Commit-Position: refs/heads/master@{#456804} [modify] https://crrev.com/cbb4ab906568a80aa3e7a314e6570cc3b8900777/chrome/android/java_sources.gni [rename] https://crrev.com/cbb4ab906568a80aa3e7a314e6570cc3b8900777/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java [rename] https://crrev.com/cbb4ab906568a80aa3e7a314e6570cc3b8900777/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d commit fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d Author: tzik <tzik@chromium.org> Date: Wed Mar 15 08:12:26 2017 Revert of Move UrlManagerTest to junit (patchset #4 id:60001 of https://codereview.chromium.org/2723783003/ ) Reason for revert: The tests in this CL got flaky after the move: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/39287 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests%2F39287%2F%2B%2Frecipes%2Fsteps%2Fchrome_junit_tests%2F0%2Fsteps%2Fchrome_junit_tests%2F0%2Fstdout failures: org.chromium.chrome.browser.physicalweb.UrlManagerTest#testUpgradeFromNone org.chromium.chrome.browser.physicalweb.UrlManagerTest#testSerializationWorksWithPoorlySerializedResult java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.chromium.chrome.browser.physicalweb.UrlManagerTest.testSerializationWorksWithPoorlySerializedResult(UrlManagerTest.java:291) java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.chromium.chrome.browser.physicalweb.UrlManagerTest.testUpgradeFromNone(UrlManagerTest.java:361) Original issue's description: > Move UrlManagerTest to junit > > UrlManagerTest does not need to be an instrumentation test, so this > change moves it from javatests/ to junit/. > > BUG= 696804 > > Review-Url: https://codereview.chromium.org/2723783003 > Cr-Commit-Position: refs/heads/master@{#456804} > Committed: https://chromium.googlesource.com/chromium/src/+/cbb4ab906568a80aa3e7a314e6570cc3b8900777 TBR=mattreynolds@chromium.org,jbudorick@chromium.org,dtrainor@chromium.org,cco3@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 696804 Review-Url: https://codereview.chromium.org/2755643002 Cr-Commit-Position: refs/heads/master@{#457030} [modify] https://crrev.com/fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d/chrome/android/java_sources.gni [rename] https://crrev.com/fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java [rename] https://crrev.com/fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae09ef656ac3228c91a6fef38f3d386ee21f6faa commit ae09ef656ac3228c91a6fef38f3d386ee21f6faa Author: cco3 <cco3@chromium.org> Date: Fri Mar 17 20:36:03 2017 Revert "Revert of Move UrlManagerTest to junit (patchset #4 id:60001 of https://codereview.chromium.org/2723783003/ )" This reverts commit fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d. Apparently the junit tests don't support @DisabledTest, so we use @Ignore instead. Also, it restores our timeout on waiting for an upgrade to 5 seconds, which apparently really did need to be that high. BUG= 696804 Review-Url: https://codereview.chromium.org/2750003006 Cr-Commit-Position: refs/heads/master@{#457875} [modify] https://crrev.com/ae09ef656ac3228c91a6fef38f3d386ee21f6faa/chrome/android/java_sources.gni [rename] https://crrev.com/ae09ef656ac3228c91a6fef38f3d386ee21f6faa/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java [rename] https://crrev.com/ae09ef656ac3228c91a6fef38f3d386ee21f6faa/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb80229542ef5f3a648a857c36c125ec9d235a68 commit bb80229542ef5f3a648a857c36c125ec9d235a68 Author: jbudorick <jbudorick@chromium.org> Date: Fri Mar 17 23:14:29 2017 Revert of Revert "Revert of Move UrlManagerTest to junit (patchset #4 id:60001 of https://codereview.chromium… (patchset #1 id:1 of https://codereview.chromium.org/2750003006/ ) Reason for revert: Failing at an elevated rate on linux_android_rel_ng. Original issue's description: > Revert "Revert of Move UrlManagerTest to junit (patchset #4 id:60001 of https://codereview.chromium.org/2723783003/ )" > > This reverts commit fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d. > > Apparently the junit tests don't support @DisabledTest, so we use @Ignore > instead. Also, it restores our timeout on waiting for an upgrade to 5 > seconds, which apparently really did need to be that high. > > BUG= 696804 > > Review-Url: https://codereview.chromium.org/2750003006 > Cr-Commit-Position: refs/heads/master@{#457875} > Committed: https://chromium.googlesource.com/chromium/src/+/ae09ef656ac3228c91a6fef38f3d386ee21f6faa TBR=dtrainor@chromium.org,cco3@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 696804 Review-Url: https://codereview.chromium.org/2755263002 Cr-Commit-Position: refs/heads/master@{#457900} [modify] https://crrev.com/bb80229542ef5f3a648a857c36c125ec9d235a68/chrome/android/java_sources.gni [rename] https://crrev.com/bb80229542ef5f3a648a857c36c125ec9d235a68/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java [rename] https://crrev.com/bb80229542ef5f3a648a857c36c125ec9d235a68/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
Comment 1 by bugdroid1@chromium.org
, Feb 28 2017