New issue
Advanced search Search tips

Issue 696787 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Remove NOTIFICATION_RETARGETING

Project Member Reported by pnoland@chromium.org, Feb 27 2017

Issue description

Remove NOTIFICATION_RETARGETING, shifting all of its remaining use scenarios to WebContentsObserver::DidOpenRequestedURL. The current system where some events are reported through DidOpenRequestedURL and some are reported through Retargeting is confusing and relies on the deprecated Notifications API. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aae574ee52af5df55c8b7175ff096481a5bfb703

commit aae574ee52af5df55c8b7175ff096481a5bfb703
Author: pnoland <pnoland@chromium.org>
Date: Mon Mar 06 21:04:21 2017

Remove the retargeting notification

Replace the retargeting notification with an additional call site for
WebContentsObserver::DidOpenRequestedURL. Adjust the two consumers of
the retargeting notification to record the information using
DidOpenRequestedURL instead.

R=nasko@chromium.org, creis@chromium.org

BUG= 696787 

Review-Url: https://codereview.chromium.org/2724433002
Cr-Commit-Position: refs/heads/master@{#454953}

[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/chrome/browser/chrome_notification_types.h
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/chrome/browser/safe_browsing/safe_browsing_navigation_observer.h
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
[delete] https://crrev.com/e8e3eea556d5713612f304b2c35e193658fa4f90/chrome/browser/tab_contents/retargeting_details.h
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/chrome/browser/ui/browser.cc
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/content/test/web_contents_observer_sanity_checker.cc
[modify] https://crrev.com/aae574ee52af5df55c8b7175ff096481a5bfb703/content/test/web_contents_observer_sanity_checker.h

Status: Fixed (was: Started)

Sign in to add a comment