New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 571056



Sign in to add a comment

Crash: NotificationPlatformBridgeMac::Display

Project Member Reported by sheriffbot@chromium.org, Feb 27 2017

Issue description

Crash Signature: NotificationPlatformBridgeMac::Display
Process Type: Browser
Platform: Mac
Channel: Canary
Version: 58.0.3025.0
Distinct Clients: 1
CPM: 0.40
Crash Reports: 1
Median Uptime: 15m:17s
Infected Clients: 0.0%

Sample Reports:
https://crash.corp.google.com/browse?q=reportid=%27997778b1c0000000%27
https://crash.corp.google.com/browse?q=reportid=%27d385ee31c0000000%27

Crash Link:
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Mac%27%20AND%20product.version%3D%2758.0.3025.0%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27NotificationPlatformBridgeMac%3A%3ADisplay%27

Crash Link (with version impact distribution):
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Mac%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27NotificationPlatformBridgeMac%3A%3ADisplay%27

Crash Stacktrace:
EXC_BAD_INSTRUCTION (0x7fff8a343e34)
#0 0x7fff8a343e34 in -[NSApplication _crashOnException:] 
#1 0x7fff8a34428e in -[NSApplication reportException:] 
#2 0x7fff8fdab701 in __handleUncaughtException 
#3 0x7fff8c737303 in _objc_terminate 
#4 0x7fff873071d0 in std::__terminate 
#5 0x7fff87306c5a in __cxa_throw 
#6 0x7fff8c736fa0 in objc_exception_throw 
#7 0x7fff8fdab10b in +[NSException raise:format:] 
#8 0x7fff8c96d1d8 in -[NSXPCEncoder _checkObject:] 
#9 0x7fff8c97e543 in -[NSXPCEncoder _encodeArrayOfObjects:forKey:] 
#10 0x7fff8c95314b in -[NSDictionary encodeWithCoder:] 
#11 0x7fff8c96d73c in -[NSXPCEncoder _encodeObject:] 
#12 0x7fff8c9610a1 in encodeInvocationArguments 
#13 0x7fff8c96d8c8 in -[NSXPCEncoder encodeInvocation:] 
#14 0x7fff8c96d73c in -[NSXPCEncoder _encodeObject:] 
#15 0x7fff8c96c329 in -[NSXPCConnection _sendInvocation:proxyNumber:remoteInterface:withErrorHandler:timeout:userInfo:] 
#16 0x7fff8c96bad2 in -[NSXPCConnection _sendInvocation:proxyNumber:remoteInterface:] 
#17 0x7fff8fd09043 in ___forwarding___ 
#18 0x7fff8fd08df7 in __forwarding_prep_0___ 
#19 0x102d8c65e in NotificationPlatformBridgeMac::Display chrome/browser/notifications/notification_platform_bridge_mac.mm:234
#20 0x102d87e37 in NativeNotificationDisplayService::Display chrome/browser/notifications/native_notification_display_service.cc:51
#21 0x102d90604 in PlatformNotificationServiceImpl::DisplayPersistentNotification chrome/browser/notifications/platform_notification_service_impl.cc:352
#22 0x101d87bc0 in base::internal::Invoker<base::internal::BindState<void base/bind_internal.h:214
#23 0x1031083cf in base::debug::TaskAnnotator::RunTask base/callback.h:68
#24 0x10312dc3a in base::MessageLoop::RunTask base/message_loop/message_loop.cc:423
#25 0x10312df8b in base::MessageLoop::DeferOrRunPendingTask base/message_loop/message_loop.cc:434
#26 0x10312e352 in base::MessageLoop::DoWork base/message_loop/message_loop.cc:527
#27 0x103131779 in base::MessagePumpCFRunLoopBase::RunWork base/message_loop/message_pump_mac.mm:420
#28 0x103122039 in base::mac::CallWithEHFrame 
#29 0x103131193 in base::MessagePumpCFRunLoopBase::RunWorkSource base/message_loop/message_pump_mac.mm:396
#30 0x7fff8fcdc5b0 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 
#31 0x7fff8fccdc61 in __CFRunLoopDoSources0 
#32 0x7fff8fccd3ee in __CFRunLoopRun 
#33 0x7fff8fccce74 in CFRunLoopRunSpecific 
#34 0x7fff8bbfba0c in HIToolbox+0x2ea0c 
#35 0x7fff8bbfb7b6 in HIToolbox+0x2e7b6 
#36 0x7fff8bbfb5bb in HIToolbox+0x2e5bb 
#37 0x7fff89fab24d in _DPSNextEvent 
#38 0x7fff89faa89a in -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 
#39 0x102cc81ff in __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke chrome/browser/chrome_browser_application_mac.mm:187
#40 0x103122039 in base::mac::CallWithEHFrame 
#41 0x102cc8138 in -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] chrome/browser/chrome_browser_application_mac.mm:186
#42 0x7fff89f9e99b in -[NSApplication run] 
#43 0x103131fbd in base::MessagePumpNSApplication::DoRun base/message_loop/message_pump_mac.mm:755
#44 0x1031315db in base::MessagePumpCFRunLoopBase::Run base/message_loop/message_pump_mac.mm:292
#45 0x10314fca2 in base::RunLoop::Run base/run_loop.cc:37
#46 0x102ccdd18 in ChromeBrowserMainParts::MainMessageLoopRun chrome/browser/chrome_browser_main.cc:2002
#47 0x101ba5063 in content::BrowserMainLoop::RunMainMessageLoopParts content/browser/browser_main_loop.cc:1182
#48 0x101ba7fd1 in content::BrowserMainRunnerImpl::Run content/browser/browser_main_runner.cc:140
#49 0x101ba0c7b in content::BrowserMain content/browser/browser_main.cc:46
#50 0x102c863df in content::ContentMainRunnerImpl::Run content/app/content_main_runner.cc:836
#51 0x102c856f5 in content::ContentMain content/app/content_main.cc:20
#52 0x1016fce7a in ChromeMain chrome/app/chrome_main.cc:113
#53 0x101681d99 in Google Chrome Canary+0xd99 
#54 0x7fff8964b5fc in libdyld.dylib+0x35fc 


Reporter: rsesek

 

Comment 1 by rsesek@chromium.org, Feb 27 2017

Cc: -rsesek@google.com rsesek@chromium.org miguelg@chromium.org peter@chromium.org
Components: UI>Notifications
Labels: -Restrict-View-EditIssue M-58 OS-Mac
Owner: miguelg@chromium.org
Status: Assigned (was: Untriaged)
List Annotations: Crashing on exception: *** -[NSXPCEncoder _checkObject:]: This coder only encodes objects that adopt NSSecureCoding (object is of class 'NSImage').

This crash only happens on macOS 10.9 because it looks like NSImage didn't start conforming to NSSecureCoding until 10.10.
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 27 2017

Labels: FoundIn-M-58
Users experienced this crash on the following builds:

Mac Canary 58.0.3025.0 -  0.72 CPM, 2 reports, 1 clients (signature NotificationPlatformBridgeMac::Display)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Blocking: 571056
Good catch https://codereview.chromium.org/2728173003/ sent out for review
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 4 2017

Labels: FoundIn-M-59
Users experienced this crash on the following builds:

Mac Canary 59.0.3030.0 -  1.23 CPM, 1 reports, 1 clients (signature NotificationPlatformBridgeMac::Display)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52f904d3bf07e423a6bb907ff6f344935532affa

commit 52f904d3bf07e423a6bb907ff6f344935532affa
Author: miguelg <miguelg@chromium.org>
Date: Mon Mar 06 19:30:34 2017

Transfer the notification icon through XPC as NSData for OSX 10.09

This is because NSImage only started conforming to NSecureCoding in 10.10

BUG= 696759 

Review-Url: https://codereview.chromium.org/2728173003
Cr-Commit-Position: refs/heads/master@{#454916}

[modify] https://crrev.com/52f904d3bf07e423a6bb907ff6f344935532affa/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm
[modify] https://crrev.com/52f904d3bf07e423a6bb907ff6f344935532affa/chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm

Labels: Merge-Request-58
Tested manually with and without this change in a 10.9 mac to confirm it fixes it.
Cc: gov...@chromium.org
+govind for merge approval, this is probably crashing for 50% calendar users using dev channel..
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d850e88b25328644823ce00fab4f66fdfeb8278

commit 5d850e88b25328644823ce00fab4f66fdfeb8278
Author: Miguel Garcia <miguelg@chromium.org>
Date: Wed Mar 08 12:21:17 2017

Transfer the notification icon through XPC as NSData for OSX 10.09

This is because NSImage only started conforming to NSecureCoding in 10.10

BUG= 696759 

Review-Url: https://codereview.chromium.org/2728173003
Cr-Commit-Position: refs/heads/master@{#454916}
(cherry picked from commit 52f904d3bf07e423a6bb907ff6f344935532affa)

Review-Url: https://codereview.chromium.org/2736223002 .
Cr-Commit-Position: refs/branch-heads/3029@{#62}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/5d850e88b25328644823ce00fab4f66fdfeb8278/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm
[modify] https://crrev.com/5d850e88b25328644823ce00fab4f66fdfeb8278/chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm

Status: Fixed (was: Assigned)

Sign in to add a comment