New issue
Advanced search Search tips

Issue 696735 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Asynchronous AcceptInvitation failure should be detectable

Project Member Reported by rsesek@chromium.org, Feb 27 2017

Issue description

In issue 691118, the Android Seccomp policy on i386 was causing SetParentPipeHandle to fail. Because failure in SetParentPipeHandle is only reported on the first failed send, though, this resulted in the main thread's MessageLoop being QuitWhenIdle() due to a ChildThreadImpl::OnChannelError(). This led to no easily detectible crash, and instead it manifested merely as a System.exit(0).

rockot@ wrote at https://bugs.chromium.org/p/chromium/issues/detail?id=691118#c21:

"This is expected behavior, but it probably makes sense to expose SetParentPipeHandle failure (be it synchronous or asynchronous) so content could be more proactive about crashing in that case."

Having a failure callback would be helpful, so Chrome could LOG(FATAL) under that condition, rather than having the renderer just exit quietly.
 

Comment 1 by roc...@chromium.org, May 29 2017

Cc: roc...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 2 by sheriffbot@chromium.org, May 29 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -roc...@chromium.org rockot@google.com
Components: -Internals>Mojo Internals>Mojo>Core
Labels: -Pri-2 -Hotlist-Recharge-Cold Pri-3
Summary: Asynchronous AcceptInvitation failure should be detectable (was: Mojo SetParentPipeHandle failure should be exposed to the embedder)
Triaging, re-titling appropriately for naming of things in the ABI.

Still potentially valid, though beyond the initial synchronous AcceptInvitation step, there are so many potential points of failure -- many of which are not related to AcceptInvitation itself -- that we ought to consider a more general purpose API for pushing internal system events to the Mojo consumer.

Status: Available (was: Untriaged)

Sign in to add a comment