The Pay button should only be enabled when the required data is available/selected. When clicked, the pay button should return a PaymentResponse.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e commit d4be8de802d4fd6e2b8ec7a85253eae7db69c15e Author: mathp <mathp@chromium.org> Date: Wed Mar 01 00:51:48 2017 [Payments] Add the pay button, and control its enabled state Depending on the data requested by the merchant, the pay button may or may not be disabled. More validation and logic to follow. BUG= 696733 TEST=PaymentSheet... interactive_ui_tests Review-Url: https://codereview.chromium.org/2715213005 Cr-Commit-Position: refs/heads/master@{#453781} [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/payments/chrome_payment_request_delegate.cc [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/payments/chrome_payment_request_delegate.h [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_method_view_controller.cc [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_sheet_view_controller.h [add] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/browser/ui/views/payments/payment_sheet_view_controller_interactive_uitest.cc [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/chrome/test/BUILD.gn [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/components/payments/content/payment_request.cc [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/components/payments/content/payment_request.h [modify] https://crrev.com/d4be8de802d4fd6e2b8ec7a85253eae7db69c15e/components/payments/content/payment_request_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6470341429052985f7e031e623f407dcf1538f09 commit 6470341429052985f7e031e623f407dcf1538f09 Author: mathp <mathp@chromium.org> Date: Wed Mar 01 20:11:15 2017 [Payments] Add a Pay button in the Order summary screen BUG= 696733 TEST=existing Review-Url: https://codereview.chromium.org/2724063002 Cr-Commit-Position: refs/heads/master@{#454008} [modify] https://crrev.com/6470341429052985f7e031e623f407dcf1538f09/chrome/browser/ui/views/payments/order_summary_view_controller.cc [modify] https://crrev.com/6470341429052985f7e031e623f407dcf1538f09/chrome/browser/ui/views/payments/order_summary_view_controller.h [modify] https://crrev.com/6470341429052985f7e031e623f407dcf1538f09/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/6470341429052985f7e031e623f407dcf1538f09/chrome/browser/ui/views/payments/payment_request_dialog_view.h [modify] https://crrev.com/6470341429052985f7e031e623f407dcf1538f09/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h [modify] https://crrev.com/6470341429052985f7e031e623f407dcf1538f09/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc [modify] https://crrev.com/6470341429052985f7e031e623f407dcf1538f09/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/6470341429052985f7e031e623f407dcf1538f09/components/payments/content/payment_request.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7 commit 4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7 Author: mathp <mathp@chromium.org> Date: Wed Mar 08 21:07:16 2017 [Payments] Return a basic card response in the PaymentResponse * Creates AutofillPaymentInstrument (and the abstract type PaymentInstrument), which returns a basic card response. * Brings PaymentAddress and BasicCardResponse from iOS code, because they can be reused when serializing the stringified basic card details. * Brings the utility functions used for PaymentAddress and BasicCardResponse. * Hooks up Complete, OnComplete and CanMakePayment in PaymentRequest. * Adds many TODOs! BUG= 696733 TEST=components_unittests, browser_tests (PaymentRequest*) Review-Url: https://codereview.chromium.org/2733953003 Cr-Commit-Position: refs/heads/master@{#455540} [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/chrome/browser/ui/views/payments/payment_request_browsertest.cc [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/content/payment_request.cc [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/content/payment_request.h [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/BUILD.gn [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/autofill_payment_instrument.cc [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/autofill_payment_instrument.h [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/basic_card_response.cc [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/basic_card_response.h [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/basic_card_response_unittest.cc [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/payment_address.cc [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/payment_address.h [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/payment_address_unittest.cc [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/payment_instrument.h [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/payment_request_data_util.cc [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/payment_request_data_util.h [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/components/payments/core/payment_request_data_util_unittest.cc [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/chrome/browser/payments/js_payment_request_manager.h [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/chrome/browser/payments/js_payment_request_manager.mm [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/chrome/browser/payments/payment_request_coordinator.h [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/chrome/browser/payments/payment_request_coordinator.mm [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/chrome/browser/payments/payment_request_coordinator_unittest.mm [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/chrome/browser/payments/payment_request_manager.mm [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/chrome/browser/payments/payment_request_util.h [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/chrome/browser/payments/payment_request_util.mm [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/web/BUILD.gn [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/web/payments/DEPS [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/web/payments/payment_request.cc [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/web/payments/payment_request_unittest.cc [add] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/web/public/payments/DEPS [modify] https://crrev.com/4b85b58e36ed9f14bfda0ca84c82f5bdfb509ab7/ios/web/public/payments/payment_request.h
Comment 1 by bugdroid1@chromium.org
, Mar 1 2017