New issue
Advanced search Search tips

Issue 696731 link

Starred by 1 user
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Integration tests do not have QUIC Request headers

Project Member Reported by ryansturm@chromium.org, Feb 27 2017 
When writing DataReductionProxy integration tests, it's observable that QUIC requests do not have request headers for LoFi images. This is because NetLogObserver does not have support for QUIC (but does have support for HTTP and H2).
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/687ef074d2b0996276993f55547873dd8e9e4246

commit 687ef074d2b0996276993f55547873dd8e9e4246
Author: ryansturm <ryansturm@chromium.org>
Date: Tue Feb 28 01:04:14 2017

Adding QUIC request headers to the net log observer

The performance logs used in integration tests
(https://codereview.chromium.org/2705413004/) do not contain the
QUIC request headers. Since QUIC and H2 are structured similarly,
this is a minor change to support outputting QUIC request headers.

BUG= 696731 

Review-Url: https://codereview.chromium.org/2715743007
Cr-Commit-Position: refs/heads/master@{#453429}

[modify] https://crrev.com/687ef074d2b0996276993f55547873dd8e9e4246/content/browser/loader/netlog_observer.cc
[modify] https://crrev.com/687ef074d2b0996276993f55547873dd8e9e4246/content/browser/loader/netlog_observer.h
[add] https://crrev.com/687ef074d2b0996276993f55547873dd8e9e4246/content/browser/loader/netlog_observer_unittest.cc
[modify] https://crrev.com/687ef074d2b0996276993f55547873dd8e9e4246/content/test/BUILD.gn

Comment 2 by ryansturm@chromium.org, Mar 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment