New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696715 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

dromaeo.* and others failing on 4 Android builders

Project Member Reported by robert...@chromium.org, Feb 27 2017

Issue description

dromaeo.jslibstylejquery failing on 4 builders



Builders failed on: 
- Android Nexus5X Perf (2): 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%282%29
- Android Nexus6 Perf (2): 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29
- Android Nexus6 WebView Perf (1): 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf%20%281%29
- Android Nexus7v2 Perf (2): 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf%20%282%29


Log: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5X_Perf__2_%2F3232%2F%2B%2Frecipes%2Fsteps%2Fdromaeo.jslibstylejquery%2F0%2Fstdout

---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<--
Traceback (most recent call last):
  RunBenchmark at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:364
    benchmark.ShouldTearDownStateAfterEachStorySetRun())
  Run at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:243
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:88
    state.RunStory(results)
  traced_function at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  RunStory at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:301
    self._current_page, self._current_tab, results)
  traced_function at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  ValidateAndMeasurePage at /b/c/b/Android_Nexus5X_Perf__2_/src/tools/perf/benchmarks/dromaeo.py:62
    self._power_metric.Stop(page, tab)
  Stop at /b/c/b/Android_Nexus5X_Perf__2_/src/tools/perf/metrics/power.py:100
    self._StopInternal()
  _StopInternal at /b/c/b/Android_Nexus5X_Perf__2_/src/tools/perf/metrics/power.py:52
    self._results = self._platform.StopMonitoringPower()
  StopMonitoringPower at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/telemetry/telemetry/core/platform.py:311
    ret_val = self._platform_backend.StopMonitoringPower()
  StopMonitoringPower at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/android_platform_backend.py:433
    return self._power_monitor.StopMonitoringPower()
  StopMonitoringPower at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_controller.py:79
    self._MergePowerResults(results, monitor.StopMonitoringPower())
  StopMonitoringPower at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py:76
    self._platform.ParseCStateSample(self._initial_cstate),
  ParseCStateSample at /b/c/b/Android_Nexus5X_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/android_platform_backend.py:497
    cstates[state] = int(times[i])
ValueError: invalid literal for int() with base 10: ''
--->8--->8--->8--->8--->8--->8--->8--->8--->8--->8--->8--->8--->8


 
Cc: -yukishiino@chromium.org -haraken@chromium.org -bashi@chromium.org sullivan@chromium.org
Components: Speed>Telemetry
Summary: dromaeo.* and others failing on 4 Android builders (was: dromaeo.* failing on 4 builders )
This seems to be affecting more than dromaeo, but also kraken, webrtc, image_decoding, power.android_acceptance and media.android.

Perhaps someone in telemetry knows what's up.
Cc: perezju@chromium.org
The bisect in  bug 696715  seems to have narrowed it down to 4 CLs, one of which is a catapult roll with only one change: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+/a75c463e8416e25de8c1d70ec210a1de89ea19a5

cc'ing Juan.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Feb 28 2017

Owner: perezju@chromium.org

=== Auto-CCing suspected CL author perezju@chromium.org ===

Hi perezju@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : perezju
  Commit : a75c463e8416e25de8c1d70ec210a1de89ea19a5
  Date   : Mon Feb 27 09:47:07 2017
  Subject: [Telemetry] Switch RunShellCommand clients to check_return=True

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : dromaeo.domcoreattr
  Metric       : dom/dom

Revision                                 Exit Code      N
chromium@453180                          0 +- N/A       20      good
chromium@453187                          0 +- N/A       20      good
chromium@453191                          0 +- N/A       20      good
chromium@453193                          0 +- N/A       20      good
chromium@453193,catapult@a75c463e84      1 +- N/A       20      bad       <--
chromium@453194                          1 +- N/A       20      bad
chromium@453207                          1 +- N/A       20      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests dromaeo.domcoreattr

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8986471182847724576

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6643123905626112


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: phoglund@chromium.org
 Issue 696666  has been merged into this issue.
Status: Started (was: Available)
A CL to fix this is in CQ: https://codereview.chromium.org/2718043005/
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bca2f43f2f037b4e83a2153dfc8737675f0d4b3c

commit bca2f43f2f037b4e83a2153dfc8737675f0d4b3c
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Feb 28 12:47:06 2017

Roll src/third_party/catapult/ 9aecbacb5..78c8d7338 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9aecbacb58c7..78c8d7338e35

$ git log 9aecbacb5..78c8d7338 --date=short --no-merges --format='%ad %ae %s'
2017-02-28 perezju [Telemetry] Clients expect "Unix" end-of-line from platform.RunCommand

Created with:
  roll-dep src/third_party/catapult
BUG= 696715 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2718903004
Cr-Commit-Position: refs/heads/master@{#453577}

[modify] https://crrev.com/bca2f43f2f037b4e83a2153dfc8737675f0d4b3c/DEPS

Tests should hopefully be green as of:
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29/builds/5149

Keeping an eye on them.
Status: Fixed (was: Started)
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment