Touch Bar search button does not always update after changing the default search engine |
||||||
Issue descriptionChrome Version: 58.0.3025.0 OS: macOS 10.12 What steps will reproduce the problem? (1) Close all windows (2) Choose Chrome -> Preferences (3) Change the default search engine What is the expected result? The Touch Bar search button should update to reflect the new default search engine What happens instead? The search button does not change I notice that if I have an NTP open in another tab the button updates immediately.
,
Oct 5 2017
Friendly ping for an update on this issue marked as Blocker.
,
Oct 11 2017
spqchan@, Gentle ping to get an update on this issue as it is marked as Blocker. Thanks..!
,
Oct 11 2017
M63 is branching soon, we will be taking only critical merges. It would be great to have a fix ASAP.
,
Oct 11 2017
Punting this to M64
,
Oct 12 2017
,
Nov 20 2017
This is marked as Beta blocker and M-64 will be branched in ~1 week time. If possible, please plan the fix before branch point. Thank you!
,
Nov 27 2017
spqchan@, Friendly ping to get as Update ASAP as M-64 will be branched in few days. Thanks..!
,
Nov 27 2017
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbf94922e7745093947ffc8c9d48029d11fcb605 commit fbf94922e7745093947ffc8c9d48029d11fcb605 Author: spqchan <spqchan@chromium.org> Date: Tue Nov 28 18:35:29 2017 [Mac] Update the Touch Bar for Default Search Engine changes Currently, if the user changes the default search engine in settings, the touch bar does not update to reflect the change. To fix this issue, the BrowserWindowTouchBar is modified so that it observers changes to the default search engine. Tests: browser test BrowserWindowTouchBarTest.SearchEngineChanges Bug: 696702 Change-Id: I92861aabf9ab2e87ba6d1d32fda975d9a10bdf26 Reviewed-on: https://chromium-review.googlesource.com/792034 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#519761} [modify] https://crrev.com/fbf94922e7745093947ffc8c9d48029d11fcb605/chrome/browser/ui/cocoa/browser_window_touch_bar.mm [modify] https://crrev.com/fbf94922e7745093947ffc8c9d48029d11fcb605/chrome/browser/ui/cocoa/browser_window_touch_bar_browsertest.mm
,
Nov 29 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by spqc...@chromium.org
, Sep 29 2017