New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 696700 link

Starred by 1 user
Status: Fixed
Owner:
█ olka@chromium.org
OOO Dec 22 - Jan 8
Closed: Nov 2017
Cc:
█ olka@chromium.org
maxmorin@chromium.org
grunell@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

media_unittests gmock spam for ReturnMixer

Project Member Reported by dalecur...@chromium.org, Feb 27 2017 
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: ReturnMixer(0x6120000f10c0)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

Please suppress these in the right places to avoid runtime and storage overhead.

https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/33842/steps/media_unittests/logs/stdio

Comment 1 by dalecur...@chromium.org, Oct 30 2017

Cc: grunell@chromium.org maxmorin@chromium.org
Labels: -Pri-3 M-64 Pri-1
Ping on this, this wastes tons of cloud log storage and processing time. More recent example:

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ASan_LSan_Tests__1_%2F39897%2F%2B%2Frecipes%2Fsteps%2Fmedia_unittests%2F0%2Fstdout

Comment 2 by dalecur...@chromium.org, Oct 30 2017

Cc: olka@chromium.org
 Issue 651276  has been merged into this issue.

Comment 3 by olka@chromium.org, Oct 31 2017

Status: Started (was: Assigned)
Oh I've never really looked at it since it was marked as P3. I did not want to waste tons of cloud storage :(
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d503b45c01c1196489f41f091013c5f2020fc67

commit 7d503b45c01c1196489f41f091013c5f2020fc67
Author: Olga Sharonova <olka@chromium.org>
Date: Tue Oct 31 17:15:10 2017

AudioRemdererMixer tests: replace unused ReturnMixer mock with actual implementation.

Bug:  696700 
Change-Id: Id318bbb47c1392b175f5da2bed042b74cca3c111
Reviewed-on: https://chromium-review.googlesource.com/746642
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512855}
[modify] https://crrev.com/7d503b45c01c1196489f41f091013c5f2020fc67/media/base/audio_renderer_mixer_unittest.cc

Comment 5 by olka@chromium.org, Nov 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment