New issue
Advanced search Search tips

Issue 696697 link

Starred by 1 user
Status: Fixed
Owner:
no...@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocking:
issue 660481
issue 731558



Sign in to add a comment

linux_chromium_rel_ng depends on buildnumber

Project Member Reported by no...@chromium.org, Feb 27 2017 
LUCI linux_chromium_rel_ng builder fails because it depends on buildnumber. Solve this.

The plan is to introduce "swarming_run_id" property at the kitchen level and update recipes to use that if buildnumber is not available. Currently builds are failing because bulidnumber cannot be passed to scripts, such as "get compile targets".

Comment 1 by no...@chromium.org, Feb 27 2017

Owner: no...@chromium.org
Status: Started (was: Untriaged)
buildnumber is currently used for upload archived build artifacts to GS, so we cannot provide fake values
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/25aa91a3bfd86f24e55e0fe20564b88269ad4042

commit 25aa91a3bfd86f24e55e0fe20564b88269ad4042
Author: Nodir Turakulov <nodir@chromium.org>
Date: Wed Mar 01 23:47:34 2017

kitchen: swarming_run_id and logging

Provide swarming_run_id property in swarming mode.

Cleanup logging: use logging instead of fmt.Println. Simplify the log
format. Exclude filename to keep length of log prefix constant to
simplify reading. We have a few files so we will figure out which file
cause a log line

R=dnj@chromium.org
BUG= 696697 

Change-Id: I514985f8ca483cf313e3a5d97b5bcec532b5d4a8
Reviewed-on: https://chromium-review.googlesource.com/447826
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/git.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/kitchen.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/recipe.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/cook_logdog.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/cook.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/cook_mode.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/cook_logdog_test.go
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/25aa91a3bfd86f24e55e0fe20564b88269ad4042

commit 25aa91a3bfd86f24e55e0fe20564b88269ad4042
Author: Nodir Turakulov <nodir@chromium.org>
Date: Wed Mar 01 23:47:34 2017

kitchen: swarming_run_id and logging

Provide swarming_run_id property in swarming mode.

Cleanup logging: use logging instead of fmt.Println. Simplify the log
format. Exclude filename to keep length of log prefix constant to
simplify reading. We have a few files so we will figure out which file
cause a log line

R=dnj@chromium.org
BUG= 696697 

Change-Id: I514985f8ca483cf313e3a5d97b5bcec532b5d4a8
Reviewed-on: https://chromium-review.googlesource.com/447826
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/git.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/kitchen.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/recipe.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/cook_logdog.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/cook.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/cook_mode.go
[modify] https://crrev.com/25aa91a3bfd86f24e55e0fe20564b88269ad4042/go/src/infra/tools/kitchen/cook_logdog_test.go
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 2 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/c9d35118a2ecc25de18dca5fc489c1f449f1c450

commit c9d35118a2ecc25de18dca5fc489c1f449f1c450
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 02 05:00:10 2017
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1d5ba2f15d92b0a3d30aa2443b838a485b631be6

commit 1d5ba2f15d92b0a3d30aa2443b838a485b631be6
Author: Nodir Turakulov <nodir@chromium.org>
Date: Tue Mar 28 18:58:36 2017

buildbucket: add build number support

Customers need buildbot-style build numbers in LUCI. Implement them in
Swarmbucket.

Since our build creation rate per builder is < 1/s, we can get away with
one entity per sequence. My experiments with cr-buildbucket-dev shown
that it is possible to create 100 builds for the same number sequence in
10s.

Introduce build_address tag that has format "<bucket>/<builder>/<number>".
Index it using TagIndex, but not use the index in the search just yet.

R=vadimsh@chromium.org
BUG= 696697 

Change-Id: I730f8f5436e69a000a2cd1b2aa3e80094af96162
Reviewed-on: https://chromium-review.googlesource.com/461319
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/proto/project_config.proto
[modify] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/proto/project_config_pb2.py
[modify] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/test/service_test.py
[add] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/sequence.py
[modify] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/service.py
[modify] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/metrics.py
[modify] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/swarming/test/swarming_test.py
[modify] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/model.py
[add] https://crrev.com/1d5ba2f15d92b0a3d30aa2443b838a485b631be6/appengine/cr-buildbucket/test/sequence_test.py
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2017

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ad002ca98209be920b6d6c408089b84d8baeaf3b

commit ad002ca98209be920b6d6c408089b84d8baeaf3b
Author: Nodir Turakulov <nodir@chromium.org>
Date: Tue Mar 28 20:56:31 2017

buildbucket: enable build numbers

R=vadimsh@chromium.org
BUG= 696697 
NOPRESUBMIT=true
NOTRY=true

Change-Id: I684653d08dcf5c352834ddcb90a1e28c9f49a28a
Reviewed-on: https://chromium-review.googlesource.com/461443
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/ad002ca98209be920b6d6c408089b84d8baeaf3b/cr-buildbucket-dev.cfg
[modify] https://crrev.com/ad002ca98209be920b6d6c408089b84d8baeaf3b/cr-buildbucket.cfg

Comment 8 by no...@chromium.org, Mar 29 2017

Status: Fixed (was: Started)

Comment 9 by no...@chromium.org, Jun 9 2017

Blocking: 731558
►

Sign in to add a comment