New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696681 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Rename |maxRetransmitTime| to |maxPacketLifeTime| in RTCDataChannel

Project Member Reported by lunalu@chromium.org, Feb 27 2017

Issue description

As titled, |maxRetransmitTime| is called |maxPacketLifeTime| in the spec https://w3c.github.io/webrtc-pc/#rtcdatachannel

 

Comment 1 by guidou@chromium.org, Feb 28 2017

Components: -Blink>MediaStream Blink>WebRTC
Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by mrobe...@twilio.com, Oct 16 2017

Is it acceptable to simply transform `maxRetransmitTime` to `maxPacketLifeTime`, or do these mean fundamentally different things? I ask, because I write a library that intends to paper over this difference between what is currently implemented in Chrome, versus Firefox, versus Safari, versus the spec, etc. webrtc/adapter may also want to implement this.

Comment 5 by mrobe...@twilio.com, Oct 16 2017

Answering my own question: based on https://www.w3.org/Bugs/Public/show_bug.cgi?id=25155 these should be the same.
Can you fix this? It results in silent creation of reliable data channels which is bad.
Components: -Blink>WebRTC Blink>WebRTC>PeerConnection
Owner: hbos@chromium.org
hbos@: Can you take a look?
Owner: deadbeef@chromium.org
Status: Started (was: Assigned)
Labels: M-70
Chrome status link, to link to in a deprecation notice: https://www.chromestatus.com/feature/5198350873788416
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035d038b828db503c8a4c597d351f8b5f04b24f8

commit 035d038b828db503c8a4c597d351f8b5f04b24f8
Author: Taylor Brandstetter <deadbeef@chromium.org>
Date: Tue Jun 19 21:55:28 2018

Add support for RTCDataChannelInit.maxPacketLifeTime.

This is just the standardized name for "maxRetransmitTime", which
we've already supported for a while.

Also adding deprecation notice saying that maxRetransmitTime is being
replaced by maxPacketLifeTime and will be removed in M70.

Bug:  chromium:696681 
Change-Id: I14dc14ebc103bb3f6a233fd753d9ffbd1dd734d6
Reviewed-on: https://chromium-review.googlesource.com/1101473
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568610}
[modify] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-createDataChannel-expected.txt
[modify] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt
[modify] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/third_party/blink/renderer/core/frame/deprecation.cc
[modify] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/third_party/blink/renderer/modules/peerconnection/rtc_data_channel_init.idl
[modify] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/tools/metrics/histograms/enums.xml

Labels: -M-70 M-69
Status: Fixed (was: Started)
Created a separate bug for removing maxRetransmitTime: https://bugs.chromium.org/p/chromium/issues/detail?id=854385

Sign in to add a comment