New issue
Advanced search Search tips

Issue 696669 link

Starred by 2 users
Status: Fixed
Owner:
hta@chromium.org
Closed: Jun 2018
Cc:
guidou@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Remove or standardize non-standard RTCDTMFSender APIs

Project Member Reported by lunalu@chromium.org, Feb 27 2017 
First, we should add a link to the spec in RTCDTMFSender.idl https://www.w3.org/TR/webrtc/#rtcdtmfsender

The following API's currently only appear in Blink and WebKit, but not in Gecko or the spec (linked above):
canInsertDTMF
duration
interToneGap
track

So, should we standardize or remove them?

Comment 1 by guidou@chromium.org, Feb 28 2017

Components: -Blink>MediaStream Blink>WebRTC

Comment 2 by guidou@chromium.org, Mar 6 2017

Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by foolip@chromium.org, Mar 9 2017

Cc: foolip@chromium.org

Comment 4 by phistuck@chromium.org, Mar 3 2018

Labels: Hotlist-Interop

Comment 5 by guidou@chromium.org, Jun 21 2018

Cc: guidou@chromium.org
Owner: hta@chromium.org
hta@: I believe you have already fixed this. Can you reassess?

Comment 7 by foolip@chromium.org, Jun 21 2018 

Nice!
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7377c09cc2191f82a0691b8343107a7ecdf1d7fd

commit 7377c09cc2191f82a0691b8343107a7ecdf1d7fd
Author: Harald Alvestrand <hta@chromium.org>
Date: Mon Jun 25 11:16:24 2018

Remove non-standard attributes from RTCDTMFSender

These attributes have been removed from the spec, or were never standard
in the first place, and have zero usage.

"Intent to remove" thread:
https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/kGS73zpPT0I

Bug:  696669 
Change-Id: Id999ab29c2a93fc7c36079196a8a924c01450066
Reviewed-on: https://chromium-review.googlesource.com/1110221
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570004}
[modify] https://crrev.com/7377c09cc2191f82a0691b8343107a7ecdf1d7fd/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createDTMFSender.html
[modify] https://crrev.com/7377c09cc2191f82a0691b8343107a7ecdf1d7fd/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7377c09cc2191f82a0691b8343107a7ecdf1d7fd/third_party/blink/renderer/modules/peerconnection/rtc_dtmf_sender.cc
[modify] https://crrev.com/7377c09cc2191f82a0691b8343107a7ecdf1d7fd/third_party/blink/renderer/modules/peerconnection/rtc_dtmf_sender.h
[modify] https://crrev.com/7377c09cc2191f82a0691b8343107a7ecdf1d7fd/third_party/blink/renderer/modules/peerconnection/rtc_dtmf_sender.idl
[modify] https://crrev.com/7377c09cc2191f82a0691b8343107a7ecdf1d7fd/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc

Comment 9 by hta@chromium.org, Jun 25 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment